Filter product variants by product & option values #12382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamil
force-pushed
the
master-filter-product-variants-by-product-and-option-values
branch
2 times, most recently
from
e6b4f5a
to
a6c5d18
Compare
AdamKasp
reviewed
Mar 4, 2021
src/Sylius/Bundle/ApiBundle/DataProvider/ChannelAwareItemDataProvider.php
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/DataProvider/ChannelAwareItemDataProvider.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/DataProvider/ChannelAwareItemDataProvider.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Doctrine/Filter/ProductVariantOptionValueFilter.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Doctrine/Filter/ProductVariantOptionValueFilter.php
Outdated
Show resolved
Hide resolved
AdamKasp
reviewed
Mar 4, 2021
src/Sylius/Bundle/ApiBundle/Doctrine/Filter/ProductVariantOptionValueFilter.php
Outdated
Show resolved
Hide resolved
GSadee
reviewed
Mar 5, 2021
src/Sylius/Bundle/ApiBundle/Doctrine/Filter/ProductVariantOptionValueFilter.php
Show resolved
Hide resolved
AdamKasp
reviewed
Mar 5, 2021
src/Sylius/Bundle/ApiBundle/Doctrine/Filter/ProductVariantOptionValueFilter.php
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Doctrine/Filter/ProductVariantOptionValueFilter.php
Show resolved
Hide resolved
GSadee
force-pushed
the
master-filter-product-variants-by-product-and-option-values
branch
from
dfce9b9
to
32f74a7
Compare
GSadee
force-pushed
the
master-filter-product-variants-by-product-and-option-values
branch
from
32f74a7
to
9073bad
Compare
pamil
deleted the
master-filter-product-variants-by-product-and-option-values
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
/api/v2/shop/product-variants?product=%2Fapi%2Fv2%2Fshop%2Fproducts%2FLoose_white_designer_T_Shirt) - my idea is thatChannelContextBuilderis only run for the "main" API request, normalizing product's IRI and going through this data provider does not trigger context builder beforehand?optionValues=/option/value/iri