Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipping method change key cost to price #12390

Merged
merged 3 commits into from
Mar 4, 2021

Conversation

SirDomin
Copy link
Contributor

Q A
Branch? 1.9
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Related tickets
License MIT

@SirDomin SirDomin requested a review from a team as a code owner February 28, 2021 22:07
@probot-autolabeler probot-autolabeler bot added API APIs related issues and PRs. Maintenance CI configurations, READMEs, releases, etc. labels Feb 28, 2021
UPGRADE-1.9.md Outdated Show resolved Hide resolved
@AdamKasp
Copy link
Contributor

AdamKasp commented Mar 1, 2021

is it enough? I thought that here we want to move logic from src/Sylius/Bundle/ApiBundle/View/CartShippingMethod.php to serializer, like in price on productVariant

@AdamKasp AdamKasp changed the base branch from 1.9 to master March 2, 2021 09:38
@AdamKasp
Copy link
Contributor

AdamKasp commented Mar 2, 2021

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "shipping-method-price" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@AdamKasp AdamKasp force-pushed the shipping-method-price branch 2 times, most recently from 9670bda to 5c4f8f4 Compare March 3, 2021 07:20
@GSadee GSadee merged commit b8b8853 into Sylius:master Mar 4, 2021
@GSadee
Copy link
Member

GSadee commented Mar 4, 2021

Thank you, @SirDomin! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants