[API] reseting password with validation #12391

arti0090 · 2021-03-01T09:23:33Z

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
License	MIT

arti0090 · 2021-03-02T06:57:13Z

I have intentionally left comments with some changes (that tested on apiplatform v2.6) that will work when endpoint will be PATCH /request-reset-password/{token} At the moment it does not work. We first need support for that version. There should be also no issue with removing these comments as my last commit is pushed 2149e87

src/Sylius/Bundle/ApiBundle/Command/ResetPassword.php

src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Customer.xml

src/Sylius/Behat/Context/Api/Shop/LoginContext.php

src/Sylius/Bundle/ApiBundle/CommandHandler/ResetPasswordHandler.php

src/Sylius/Bundle/ApiBundle/DataProvider/ResetPasswordCustomerDataProvider.php

src/Sylius/Bundle/ApiBundle/spec/CommandHandler/RequestResetPasswordTokenHandlerSpec.php

src/Sylius/Bundle/ApiBundle/DataProvider/ResetPasswordItemDataProvider.php

src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/ResetPassword.xml

Co-authored-by: Adam Kasperczak <adamkasperczak123@gmail.com>

lchrusciel · 2021-03-04T08:36:34Z

src/Sylius/Bundle/ApiBundle/Validator/Constraints/ConfirmResetPasswordValidator.php

+use Webmozart\Assert\Assert;
+
+/** @experimental */
+final class ConfirmResetPasswordValidator extends ConstraintValidator


Missing spec for this class

lchrusciel · 2021-03-04T08:40:19Z

src/Sylius/Bundle/ApiBundle/spec/CommandHandler/ResetPasswordHandlerSpec.php

+        $userRepository->findOneBy(['passwordResetToken' => 'TOKEN'])->willReturn($shopUser);
+        $metadata->getParameter('resetting')->willReturn(['token' => ['ttl' => 'P5D']]);
+
+        $shopUser->isPasswordRequestNonExpired(Argument::that(function(\DateInterval $dateInterval ) {


Suggested change

$shopUser->isPasswordRequestNonExpired(Argument::that(function(\DateInterval $dateInterval ) {

$shopUser->isPasswordRequestNonExpired(Argument::that(function(\DateInterval $dateInterval) {

Same below

GSadee · 2021-03-04T11:04:43Z

src/Sylius/Behat/Context/Api/Shop/LoginContext.php

+    /**
+     * @When /^I follow link on (my) email to reset my password$/
+     */
+    public function iFollowLinkOnMyEmailToResetPassword(UserInterface $user): void


Suggested change

public function iFollowLinkOnMyEmailToResetPassword(UserInterface $user): void

public function iFollowLinkOnMyEmailToResetPassword(ShopUserInterface $user): void

?

GSadee · 2021-03-04T11:08:16Z

src/Sylius/Bundle/ApiBundle/Command/ResetPassword.php

+    public function getResetPasswordToken(): string
+    {
+        return $this->resetPasswordToken;
+    }
+
+    public function setResetPasswordToken(string $token): void
+    {
+        $this->resetPasswordToken = $token;
+    }


Are these methods needed as $resetPasswordToken has public access?

GSadee · 2021-03-04T11:09:55Z

src/Sylius/Bundle/ApiBundle/CommandHandler/ResetPasswordHandler.php

+        }
+
+        if ($command->getResetPasswordToken() !== $user->getPasswordResetToken()) {
+            throw new \InvalidArgumentException('Password reset token do not match.');


Suggested change

throw new \InvalidArgumentException('Password reset token do not match.');

throw new \InvalidArgumentException('Password reset token does not match.');

GSadee · 2021-03-04T11:10:57Z

src/Sylius/Bundle/ApiBundle/CommandHandler/ResetPasswordHandler.php

+            throw new \InvalidArgumentException('Password reset token do not match.');
+        }
+
+        $user->setPlainPassword($command->newPassword);


Do you check somewhere the new password with the password confirmation?

GSadee · 2021-03-04T11:12:49Z

src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/ResetPassword.xml

+        <attribute name="messenger">input</attribute>
+
+        <collectionOperations>
+            <collectionOperation name="shop_password_reset_request">


Suggested change

<collectionOperation name="shop_password_reset_request">

<collectionOperation name="shop_request_reset_password">

GSadee · 2021-03-04T11:12:59Z

src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/ResetPassword.xml

+        </collectionOperations>
+
+        <itemOperations>
+            <itemOperation name="shop_password_reset">


Suggested change

<itemOperation name="shop_password_reset">

<itemOperation name="shop_reset_password">

GSadee · 2021-03-04T11:27:34Z

src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/ResetPassword.xml

+                    <attribute name="groups">shop:reset_password:update</attribute>
+                </attribute>
+                <attribute name="openapi_context">
+                    <attribute name="summary">Password reset</attribute>


Suggested change

<attribute name="summary">Password reset</attribute>

<attribute name="summary">Resets password</attribute>

to be consistent with other endpoints

GSadee · 2021-03-04T11:30:22Z

src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/ResetPassword.xml

+                    <attribute name="groups">shop:reset_password:create</attribute>
+                </attribute>
+                <attribute name="openapi_context">
+                    <attribute name="summary">Request password reset</attribute>


Suggested change

<attribute name="summary">Request password reset</attribute>

<attribute name="summary">Requests password reset</attribute>

GSadee · 2021-03-04T11:33:08Z

Thank you, @arti0090! 🎉

…ord PR (arti0090) This PR was merged into the 1.10-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | License | MIT Continuation of #12391 Commits ------- 08adcf3 add missing specs and make fixes to reset password PR

This PR was merged into the 1.10-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Continuation of #12391  Commits ------- 2fdd995 [API] Adjust reset password requests

arti0090 requested a review from a team as a code owner March 1, 2021 09:23

probot-autolabeler bot added the API APIs related issues and PRs. label Mar 1, 2021

arti0090 changed the title ~~[WIP][API] reseting password with validation~~ [API] reseting password with validation Mar 2, 2021

arti0090 mentioned this pull request Mar 2, 2021

[API] Make Sylius compatible with api-platform v2.6 #12396

Closed

5 tasks

AdamKasp reviewed Mar 3, 2021

View reviewed changes

src/Sylius/Bundle/ApiBundle/Command/ResetPassword.php Outdated Show resolved Hide resolved

AdamKasp reviewed Mar 3, 2021

View reviewed changes

src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Customer.xml Outdated Show resolved Hide resolved

lchrusciel reviewed Mar 3, 2021

View reviewed changes

arti0090 force-pushed the api-resetting-password-part-2 branch 2 times, most recently from bb0a61d to 50384fb Compare March 3, 2021 09:56

arti0090 added 6 commits March 3, 2021 10:59

reseting password with validation

d230f15

change endpoint from PATCH to POST

ce84ee8

remove comments

788a0f4

improve handlers and add tests

c39cdac

update swagger doc

8c87f04

remove unused data transformer, change route to PATCH and fixes

c0a15e0

arti0090 force-pushed the api-resetting-password-part-2 branch from 50384fb to c0a15e0 Compare March 3, 2021 10:00

fix email by locale

cdb7fd5

lchrusciel reviewed Mar 3, 2021

View reviewed changes

src/Sylius/Bundle/ApiBundle/DataProvider/ResetPasswordItemDataProvider.php Show resolved Hide resolved

arti0090 added 2 commits March 3, 2021 12:29

add phpspec for data provider

2b369fa

add data provider spec

4816e27

AdamKasp approved these changes Mar 4, 2021

View reviewed changes

src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/ResetPassword.xml Outdated Show resolved Hide resolved

remove empty line from resetPassword.xml

02212e4

Co-authored-by: Adam Kasperczak <adamkasperczak123@gmail.com>

lchrusciel approved these changes Mar 4, 2021

View reviewed changes

GSadee approved these changes Mar 4, 2021

View reviewed changes

GSadee merged commit 4cfede9 into Sylius:master Mar 4, 2021

arti0090 mentioned this pull request Mar 4, 2021

[API] Add missing specs and make fixes to reset password PR #12419

Merged

lchrusciel mentioned this pull request Mar 4, 2021

[API] Adjust reset password requests #12420

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[API] reseting password with validation #12391

[API] reseting password with validation #12391

arti0090 commented Mar 1, 2021

arti0090 commented Mar 2, 2021

lchrusciel Mar 4, 2021

lchrusciel Mar 4, 2021

GSadee Mar 4, 2021

GSadee Mar 4, 2021

GSadee Mar 4, 2021

GSadee Mar 4, 2021

GSadee Mar 4, 2021

GSadee Mar 4, 2021

GSadee Mar 4, 2021

GSadee Mar 4, 2021

GSadee commented Mar 4, 2021

	$shopUser->isPasswordRequestNonExpired(Argument::that(function(\DateInterval $dateInterval ) {
	$shopUser->isPasswordRequestNonExpired(Argument::that(function(\DateInterval $dateInterval) {

	public function iFollowLinkOnMyEmailToResetPassword(UserInterface $user): void
	public function iFollowLinkOnMyEmailToResetPassword(ShopUserInterface $user): void

	throw new \InvalidArgumentException('Password reset token do not match.');
	throw new \InvalidArgumentException('Password reset token does not match.');

	<collectionOperation name="shop_password_reset_request">
	<collectionOperation name="shop_request_reset_password">

	<itemOperation name="shop_password_reset">
	<itemOperation name="shop_reset_password">

	<attribute name="summary">Password reset</attribute>
	<attribute name="summary">Resets password</attribute>

	<attribute name="summary">Request password reset</attribute>
	<attribute name="summary">Requests password reset</attribute>

[API] reseting password with validation #12391

[API] reseting password with validation #12391

Conversation

arti0090 commented Mar 1, 2021

arti0090 commented Mar 2, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GSadee commented Mar 4, 2021