[API] Adjust reset password requests #12420
Conversation
| @@ -15,15 +15,15 @@ | |||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
| xsi:schemaLocation="https://api-platform.com/schema/metadata https://api-platform.com/schema/metadata/metadata-2.0.xsd" | |||
| > | |||
| <resource class="Sylius\Bundle\ApiBundle\Command\ResetPassword" shortName="ResetPassword"> | |||
| <resource class="Sylius\Bundle\ApiBundle\Command\ResetPassword" shortName="ResetPasswordRequest"> | |||
There was a problem hiding this comment.
I would leave as it was, now shortName reflects only specific (request) action, as before it reflected for resource/action that were for reset password
There was a problem hiding this comment.
I would be also for changing the command name, now it is quite confusing
| @@ -61,7 +61,7 @@ public function iWantToLogIn(): void | |||
| */ | |||
| public function iWantToResetPassword(): void | |||
| { | |||
| $this->request = Request::create('shop', 'request-reset-password', 'Bearer'); | |||
| $this->request = Request::create('shop', 'reset-password-requests', 'Bearer'); | |||
There was a problem hiding this comment.
Well I would call here also @GSadee as, first version was reset-password-request, then it was suggested to change to reqest-reset-password and PATCH reset-password/{token} now it is changed to reset-password-requests (plural form), and from what I see in our task there was suggested to use singular reset-password-request
There was a problem hiding this comment.
To be honest, I got a little lost in what these endpoints should look like, the current form is consistent with endpoints like apply-coupon or change-quantity, but these ones should be based on the API resource, so this is a good change.
|
Thank you, Łukasz! 🥇 |
Continuation of #12391