Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Locale] Current locale set on request #12458

Merged
merged 7 commits into from Apr 15, 2021
Merged

[Locale] Current locale set on request #12458

merged 7 commits into from Apr 15, 2021

Conversation

lchrusciel
Copy link
Member

@lchrusciel lchrusciel commented Mar 19, 2021 •
edited by SirDomin

Q A
Branch? 1.9
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Note. PhpUnit tests were replaced with behat tests

@lchrusciel lchrusciel requested a review from a team as a code owner March 19, 2021 13:43
@pamil pamil closed this Mar 19, 2021
@pamil pamil reopened this Mar 19, 2021
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Apr 13, 2021
@SirDomin SirDomin changed the title [WIP][Locale] Current locale set on request [Locale] Current locale set on request Apr 13, 2021
@SirDomin SirDomin added the Bug Confirmed bugs or bugfixes. label Apr 13, 2021
@lchrusciel lchrusciel mentioned this pull request Apr 14, 2021
Closed
@GSadee GSadee merged commit a868923 into Sylius:1.9 Apr 15, 2021
@GSadee
Copy link
Member

GSadee commented Apr 15, 2021

Thanks, Łukasz! 🎉

@lchrusciel lchrusciel deleted the locale-issue branch April 19, 2021 14:13
@lchrusciel lchrusciel mentioned this pull request Apr 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirDomin SirDomin SirDomin left review comments

@GSadee GSadee GSadee approved these changes

@AdamKasp AdamKasp AdamKasp approved these changes

@arti0090 arti0090 arti0090 approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lchrusciel @GSadee @SirDomin @AdamKasp @arti0090 @pamil