Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Api] Product has last 3 reviews by default #12483

Merged
merged 6 commits into from Mar 30, 2021
Merged

[Api] Product has last 3 reviews by default #12483

merged 6 commits into from Mar 30, 2021

Conversation

SirDomin
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
License MIT

@SirDomin SirDomin requested a review from a team as a code owner March 26, 2021 07:47
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Mar 26, 2021
@SirDomin SirDomin force-pushed the last-three-reviews branch 3 times, most recently from 8fefe1a to 47965c3 Compare March 26, 2021 08:12
lchrusciel
lchrusciel reviewed Mar 26, 2021
View reviewed changes
src/Sylius/Bundle/ApiBundle/Resources/config/serialization/ProductReview.xml Outdated Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/Resources/config/serialization/ProductReview.xml Outdated
@@ -20,31 +20,38 @@
<group>product_review:read</group>
</attribute>
<attribute name="createdAt">
<group>product_review:read</group>
</attribute>
<group>product_review:read</group>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you've touched this place anyway, can we adjust previous serialization groups to admin:product_review:read? Can be done in separate PR

src/Sylius/Bundle/ApiBundle/Serializer/ProductSerializer.php Outdated Show resolved Hide resolved
GSadee
GSadee reviewed Mar 26, 2021
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a need for adding a filter with sorting product reviews

src/Sylius/Bundle/ApiBundle/Resources/config/serialization/ProductReview.xml Outdated Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/Serializer/ProductSerializer.php Outdated Show resolved Hide resolved
@SirDomin SirDomin force-pushed the last-three-reviews branch 2 times, most recently from 1fa4671 to 21b91f5 Compare March 29, 2021 11:47
GSadee
GSadee reviewed Mar 29, 2021
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the rebase is needed

src/Sylius/Behat/Context/Api/Shop/ProductContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Resources/config/services/contexts/api/shop.xml Outdated Show resolved Hide resolved
@GSadee GSadee merged commit 9ff528f into Sylius:master Mar 30, 2021
@GSadee
Copy link
Member

GSadee commented Mar 30, 2021

Thank you, @SirDomin! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel left review comments

@GSadee GSadee GSadee approved these changes

@AdamKasp AdamKasp AdamKasp approved these changes

@arti0090 arti0090 arti0090 approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SirDomin @GSadee @lchrusciel @AdamKasp @arti0090