Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed find files in yaml standards #12496

Merged
merged 1 commit into from Apr 7, 2021
Merged

Conversation

sspooky13
Copy link
Contributor

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Hello, I am glad you upgrade dependency to yaml-standards but you changed only version number and you didn't change logic to find files 馃槄, now you need to use wildcard to find files.

I take this as feedback that changelog is not written well. I will be glad for every help how to write it better or what should I do to make sure this doesn't happen again? 馃

Thank you in advance 馃

@sspooky13 sspooky13 requested a review from a team as a code owner March 30, 2021 21:15
@probot-autolabeler probot-autolabeler bot added Admin AdminBundle related issues and PRs. Shop ShopBundle related issues and PRs. labels Mar 30, 2021
@pamil pamil merged commit 3ef1846 into Sylius:master Apr 7, 2021
@pamil
Copy link
Contributor

pamil commented Apr 7, 2021

Thank you, Peter! 馃

@sspooky13 sspooky13 deleted the yaml-standards branch April 17, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin AdminBundle related issues and PRs. Shop ShopBundle related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants