[API] Validating shipment that was shipped #12497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arti0090
commented
Mar 31, 2021
•
arti0090
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
AdamKasp
approved these changes
Mar 31, 2021
GSadee
reviewed
Apr 1, 2021
src/Sylius/Bundle/ApiBundle/CommandHandler/Checkout/ShipShipmentHandler.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/DataTransformer/ShipmentIdAwareInputCommandDataTransformer.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Command/SendShipmentConfirmationEmail.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Command/SendShipmentConfirmationEmail.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Shipment.xml
Outdated
Show resolved
Hide resolved
probot-autolabeler
bot
added
the
Maintenance
arti0090
force-pushed
the
validation-ship-shipping
branch
2 times, most recently
from
96062c0
to
e95c793
Compare
AdamKasp
approved these changes
Apr 1, 2021
lchrusciel
reviewed
Apr 2, 2021
src/Sylius/Bundle/ApiBundle/Validator/Constraints/ShipmentNotShippedStateValidator.php
Outdated
Show resolved
Hide resolved
...ius/Bundle/ApiBundle/spec/DataTransformer/ShipmentIdAwareInputCommandDataTransformerSpec.php
Outdated
Show resolved
Hide resolved
GSadee
reviewed
Apr 6, 2021
GSadee
reviewed
Apr 6, 2021
GSadee
reviewed
Apr 7, 2021
arti0090
force-pushed
the
validation-ship-shipping
branch
from
4341c66
to
157d43d
Compare
arti0090
force-pushed
the
validation-ship-shipping
branch
from
157d43d
to
f052aef
Compare
GSadee
approved these changes
Apr 7, 2021
|
Thanks, @arti0090! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.