Convert iri to code in command AddProductReview #12498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tomanhez
changed the title
Tomanhez
force-pushed
the
convert-iri-to-code-in-command-add-product-review
branch
2 times, most recently
from
b07cb55
to
507c828
Compare
AdamKasp
approved these changes
Mar 31, 2021
GSadee
reviewed
Mar 31, 2021
.../Bundle/ApiBundle/Serializer/AddProductReviewCommandFieldItemIriToIdentifierDenormalizer.php
Show resolved
Hide resolved
Comment on lines
+56
to
+63
| $denormalizedInput = $this->objectNormalizer->denormalize($data, $this->getInputClassName($context), $format, $context); | ||
|
|
||
| if ($this->commandAwareInputDataTransformer->supportsTransformation($denormalizedInput, $type, $context)) { | ||
| return $this->commandAwareInputDataTransformer->transform($denormalizedInput, $type, $context); | ||
| } | ||
|
|
||
| return $denormalizedInput; |
There was a problem hiding this comment.
What is the problem with?:
Suggested change
| $denormalizedInput = $this->objectNormalizer->denormalize($data, $this->getInputClassName($context), $format, $context); | |
| if ($this->commandAwareInputDataTransformer->supportsTransformation($denormalizedInput, $type, $context)) { | |
| return $this->commandAwareInputDataTransformer->transform($denormalizedInput, $type, $context); | |
| } | |
| return $denormalizedInput; | |
| return $this->objectNormalizer->denormalize($data, $this->getInputClassName($context), $format, $context); |
Data transformer should be used regardless of that we are decorating denormalizer or not
GSadee
reviewed
Mar 31, 2021
.../Bundle/ApiBundle/Serializer/AddProductReviewCommandFieldItemIriToIdentifierDenormalizer.php
Show resolved
Hide resolved
Tomanhez
force-pushed
the
convert-iri-to-code-in-command-add-product-review
branch
from
507c828
to
3521679
Compare
|
Thanks, Tomasz! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is extension and improvement for create generic transformation command field iri's to code: #12487