Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ProductBundle] Add validation for product meta keywords & description #12519

Merged
merged 3 commits into from Sep 14, 2023
Merged

[ProductBundle] Add validation for product meta keywords & description #12519

merged 3 commits into from Sep 14, 2023

Conversation

DieterHolvoet
Copy link
Contributor

@DieterHolvoet DieterHolvoet commented Apr 8, 2021 •
edited by jakubtobiasz

Q A
Branch? 1.12
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@DieterHolvoet DieterHolvoet requested a review from a team as a code owner April 8, 2021 16:22
@Rafikooo
Copy link
Contributor

Hello Dieter Holvoet, thank you for your contribution, and sorry for the long response time. If you still want to contribute please change the base branch to Sylius 1.11 as Sylius 1.7 is no longer supported. We need to provide a behat test for this case, if you fill up to do it, let us know, if not, we will finish it in the near future. Wish you all the best 🚀

@coldic3 coldic3 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). UX Issues and PRs aimed at improving User eXperience. labels Jan 31, 2023
@probot-autolabeler probot-autolabeler bot added Docker Docker-related issues and PRs. Maintenance CI configurations, READMEs, releases, etc. labels Sep 13, 2023
@jakubtobiasz jakubtobiasz changed the base branch from 1.7 to 1.13 September 13, 2023 11:54
@jakubtobiasz jakubtobiasz changed the base branch from 1.13 to 1.12 September 13, 2023 11:54
@github-actions
Copy link

github-actions bot commented Sep 13, 2023 •
edited

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Sep 13, 2023
@SzymonFilipek
Copy link

/bns:deploy

@SzymonFilipek
Copy link

/bns:start

SzymonFilipek
SzymonFilipek approved these changes Sep 14, 2023
View reviewed changes
Copy link

@SzymonFilipek SzymonFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes passed QA check

@GSadee GSadee merged commit 67e1972 into Sylius:1.12 Sep 14, 2023
25 checks passed
@GSadee
Copy link
Member

GSadee commented Sep 14, 2023

Thank you, Dieter! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@SzymonFilipek SzymonFilipek SzymonFilipek approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Docker Docker-related issues and PRs. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance CI configurations, READMEs, releases, etc. UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@DieterHolvoet @Rafikooo @SzymonFilipek @GSadee @coldic3 @jakubtobiasz