[API]Unify change quantity endpoint with other orders endpoints #12530
Conversation
arti0090
commented
Apr 14, 2021
•
arti0090
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
probot-autolabeler
bot
added
API
|
|
src/Sylius/Bundle/ApiBundle/Command/Cart/ChangeItemQuantityInCart.php
Outdated
Show resolved
Hide resolved
| { | ||
| public function transform($object, string $to, array $context = []) | ||
| { | ||
| $object->setOrderItemId($this->getOrderItemIdFromUri($context['request_uri'])); |
There was a problem hiding this comment.
I wonder if you can get some more information from context to choose this id in a better way instead of getting the last part of IRI. The current solution works for the implemented endpoint, but is not a generic one, what could be problematic in future.
There was a problem hiding this comment.
Unfortunatelly there are 3 places where there is ID 1st one was this, 2nd was full request ( with hostname) and 3rd place were orderItemId's that were in order ( but this is not something we could use) hence I choose this one
src/Sylius/Bundle/ApiBundle/DataTransformer/OrderItemIdAwareInputCommandDataTransformer.php
Outdated
Show resolved
Hide resolved
arti0090
force-pushed
the
change-quantity-endpoint
branch
from
c41e82b
to
76a573a
Compare
| public function transform($object, string $to, array $context = []) | ||
| { | ||
| $explodedUri = explode('/', $context['request_uri']); |
There was a problem hiding this comment.
Can we fetch from the context that this is really our endpoint with orderItemId at the end?
There was a problem hiding this comment.
This Transformer is longer exist :D thanks to your comment I changed it to subresource one and it works fine
…ody value to quantity
arti0090
force-pushed
the
change-quantity-endpoint
branch
from
6f81902
to
d161006
Compare
|
|
||
| public function setSubresourceId(?string $subresourceId): void | ||
| { | ||
| $this->orderItemId= $subresourceId; |
There was a problem hiding this comment.
| $this->orderItemId= $subresourceId; | |
| $this->orderItemId = $subresourceId; |
|
Thank you, @arti0090! 🥇 |
