[Api] upgrade taxon filter on product #12534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AdamKasp
commented
Apr 15, 2021
AdamKasp
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
arti0090
reviewed
Apr 15, 2021
SirDomin
reviewed
Apr 15, 2021
features/product/viewing_products/viewing_products_from_specific_taxon.feature
Show resolved
Hide resolved
AdamKasp
force-pushed
the
api-upgrade-taxon-filter-on-product
branch
3 times, most recently
from
bd55c46
to
f46a620
Compare
AdamKasp
force-pushed
the
api-upgrade-taxon-filter-on-product
branch
from
f46a620
to
ad98b6c
Compare
GSadee
reviewed
Apr 16, 2021
src/Sylius/Bundle/ApiBundle/Resources/config/services/filters.xml
Outdated
Show resolved
Hide resolved
GSadee
force-pushed
the
api-upgrade-taxon-filter-on-product
branch
from
f7b2a13
to
889f37d
Compare
arti0090
approved these changes
Apr 16, 2021
stloyd
reviewed
Apr 16, 2021
AdamKasp
force-pushed
the
api-upgrade-taxon-filter-on-product
branch
from
9beed8e
to
886d9d2
Compare
AdamKasp
commented
Apr 26, 2021
GSadee
approved these changes
Apr 26, 2021
| $this->iriConverter = $iriConverter; | ||
| } | ||
|
|
||
| public function filterProperty(string $property, $value, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, string $operationName = null) |
There was a problem hiding this comment.
Should be refactor to several lines
| $this->beConstructedWith($managerRegistry, $iriConverter); | ||
| } | ||
|
|
||
| function it_adds_taxon_filter_if_property_is_product_taxon( |
There was a problem hiding this comment.
Suggested change
| function it_adds_taxon_filter_if_property_is_product_taxon( | |
| function it_adds_taxon_filter_if_property_is_taxon( |
|
Thank you, Adam! 🥇 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.