Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API][Checkout] Add tag to promotion scenario #12544

Merged
merged 1 commit into from Apr 20, 2021
Merged

[API][Checkout] Add tag to promotion scenario #12544

merged 1 commit into from Apr 20, 2021

Conversation

lchrusciel
Copy link
Member

@lchrusciel lchrusciel commented Apr 19, 2021 •
edited

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
License MIT

The rest of the scenarios behave more or less properly, but requires additional code to handle 500

@lchrusciel lchrusciel requested a review from a team as a code owner April 19, 2021 13:02
@lchrusciel lchrusciel added API APIs related issues and PRs. Feature New feature proposals. labels Apr 19, 2021
@GSadee GSadee merged commit 8bead33 into Sylius:master Apr 20, 2021
@GSadee
Copy link
Member

GSadee commented Apr 20, 2021

Thanks, Łukasz! 🥇

@lchrusciel lchrusciel deleted the promotion-scenario branch April 20, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Feature New feature proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lchrusciel @GSadee