Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Validate if product or variant is enabled #12579

Merged
merged 2 commits into from May 5, 2021
Merged

[API] Validate if product or variant is enabled #12579

merged 2 commits into from May 5, 2021

Conversation

arti0090
Copy link
Contributor

@arti0090 arti0090 commented May 3, 2021

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

@arti0090 arti0090 requested a review from a team as a code owner May 3, 2021 07:40
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label May 3, 2021
@arti0090 arti0090 force-pushed the api-adding-disabled-product branch from 360cba7 to 5379e17 Compare May 3, 2021 07:54
@arti0090 arti0090 force-pushed the api-adding-disabled-product branch 3 times, most recently from 2944681 to a7d2bc4 Compare May 4, 2021 09:58
@arti0090 arti0090 force-pushed the api-adding-disabled-product branch from a7d2bc4 to 47eab59 Compare May 4, 2021 10:00
@arti0090 arti0090 mentioned this pull request May 5, 2021
Closed
@arti0090 arti0090 force-pushed the api-adding-disabled-product branch from 47eab59 to 2c82189 Compare May 5, 2021 08:54
@AdamKasp AdamKasp merged commit e365426 into Sylius:master May 5, 2021
@AdamKasp
Copy link
Contributor

AdamKasp commented May 5, 2021

Thanks, @arti0090! 🎉

@GSadee GSadee mentioned this pull request May 6, 2021
Merged
AdamKasp added a commit that referenced this pull request May 7, 2021
@AdamKasp
bug #12604 [API] Cherry pick commits on 1.9 branch for validating if …
7e36ac9 
…product is enabled during adding to cart (arti0090, GSadee)

This PR was merged into the 1.9 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.9
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | from #12579
| License         | MIT


Commits
-------

16c6611 [API] Validate if product or variant is enabled
12ca041 add missing behat scenario
29df096 [API] Adjust PHPSpec class for ProductOrVariantEnabledValidator on 1.9 branch
07c1700 change validation message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirDomin SirDomin SirDomin approved these changes

@AdamKasp AdamKasp AdamKasp approved these changes

@Tomanhez Tomanhez Tomanhez approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arti0090 @AdamKasp @SirDomin @Tomanhez