Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Api]Fix isAllowedProperty return type in ReflectionExtractor #12581

Merged
merged 2 commits into from May 4, 2021

Conversation

Tomanhez
Copy link
Contributor

@Tomanhez Tomanhez commented May 4, 2021

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

Problem:
Screenshot 2021-05-04 at 10 01 24
Adding boolval fix this problem:
Screenshot 2021-05-04 at 10 19 40

@Tomanhez Tomanhez requested a review from a team as a code owner May 4, 2021 08:26
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label May 4, 2021
@Tomanhez Tomanhez changed the title Fix isAllowedProperty return type in ReflectionExtractor [Api]Fix isAllowedProperty return type in ReflectionExtractor May 4, 2021
@Tomanhez Tomanhez added the Bug Confirmed bugs or bugfixes. label May 4, 2021
Co-authored-by: Joseph Bielawski <stloyd@users.noreply.github.com>
@pamil pamil merged commit 8fb52b4 into Sylius:master May 4, 2021
@pamil
Copy link
Contributor

pamil commented May 4, 2021

Thank you, Tomasz! 🥇

@Tomanhez
Copy link
Contributor Author

Tomanhez commented May 4, 2021

symfony/symfony#41103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs. Bug Confirmed bugs or bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants