Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country api resource shouldn't have created/updated at #12596

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Conversation

kayue
Copy link
Contributor

@kayue kayue commented May 5, 2021

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

Country object doesn't have created/updated at field. It shouldn't be defined in api resources.

@kayue kayue requested a review from a team as a code owner May 5, 2021 01:01
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label May 5, 2021
@GSadee GSadee added the Bug Confirmed bugs or bugfixes. label Jun 14, 2021
@GSadee GSadee changed the base branch from master to 1.9 June 14, 2021 10:41
@GSadee
Copy link
Member

GSadee commented Jun 14, 2021

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "patch-8" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@GSadee
Copy link
Member

GSadee commented Jun 14, 2021

Thank you, @kayue! 🎉

@GSadee GSadee merged commit 78b1e81 into Sylius:1.9 Jun 14, 2021
@kayue kayue deleted the patch-8 branch July 2, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs. Bug Confirmed bugs or bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants