[Docs] Add and improve new api docs #12599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AdamKasp
commented
May 5, 2021
AdamKasp
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| License | MIT |
AdamKasp
added
Documentation
arti0090
reviewed
May 5, 2021
docs/customization/api.rst
Outdated
| ================================== | ||
|
|
||
| Let's assume that your shop offer only digital products so you don't need setting shipment method at all. | ||
| To remove endpoint you only need to delete unnecessary configuration from ``config/api_platform/Order.xml`` |
There was a problem hiding this comment.
Is this sentence true? I mean we have some underlying logic that changes states of cart and checkout. Speaking of endpoint only POV, well we can just remove the endpoint and go drink some margarita 🍸 , but I don't think we can finish checkout process 🙁
There was a problem hiding this comment.
yes, but actually no :D
if you have only one shipping method and enabled option Skip shipping step if only one shipping method is available? on the channel, while checkout you don't need to set shipping method :)
you can check how it works on UI :)
CoderMaggie
reviewed
May 5, 2021
AdamKasp
force-pushed
the
add-and-improve-new-api-docs
branch
from
05db891
to
95b0f0a
Compare
GSadee
reviewed
May 7, 2021
AdamKasp
force-pushed
the
add-and-improve-new-api-docs
branch
from
95b0f0a
to
004f4e1
Compare
GSadee
approved these changes
May 7, 2021
|
Thanks, Adam! 🥇 |
lchrusciel
reviewed
May 10, 2021
Comment on lines
+15
to
+24
| # config/packages/api_platform.yaml | ||
| api_platform: | ||
| mapping: | ||
| paths: | ||
| - '%kernel.project_dir%/vendor/sylius/sylius/src/Sylius/Bundle/ApiBundle/Resources/config/api_resources' | ||
| - '%kernel.project_dir%/config/api_platform' | ||
| patch_formats: | ||
| json: ['application/merge-patch+json'] | ||
| swagger: | ||
| versions: [3] |
There was a problem hiding this comment.
Can we provide this config in Sylius Standard?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.