Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Cherry pick commits on 1.9 branch for validating if product is enabled during adding to cart #12604

Merged
merged 4 commits into from
May 7, 2021

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented May 6, 2021

Q A
Branch? 1.9
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets from #12579
License MIT

@GSadee GSadee added API APIs related issues and PRs. Bug Confirmed bugs or bugfixes. labels May 6, 2021
@GSadee GSadee requested a review from a team as a code owner May 6, 2021 09:33
@AdamKasp AdamKasp merged commit 7e36ac9 into Sylius:1.9 May 7, 2021
@AdamKasp
Copy link
Contributor

AdamKasp commented May 7, 2021

Thanks, Grzegorz! 🥇

@GSadee GSadee deleted the api-adding-disabled-product branch May 7, 2021 10:58
GSadee added a commit that referenced this pull request May 7, 2021
This PR was merged into the 1.9 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         |  1.9
| Bug fix?        | yes (kind of)
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | same PR as #12598 but for 1.9 branch. This branch continues #12604
| License         | MIT

Commits
-------

43f2068 [API] Adding product from another channel
071eb27 Add fixes that were working on master
1834674 Change validation message to be consistent and move message to correct bundle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs. Bug Confirmed bugs or bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants