Adding product from another channel bugfix #12609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arti0090
commented
May 7, 2021
arti0090
commented
| Q | A |
|---|---|
| Branch? | 1.9 |
| Bug fix? | yes (kind of) |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | same PR as #12598 but for 1.9 branch. This branch continues #12604 |
| License | MIT |
arti0090
force-pushed
the
adding-product-from-another-channel-bugfix
branch
2 times, most recently
from
ddb9161
to
5b9d4d6
Compare
GSadee
reviewed
May 7, 2021
src/Sylius/Bundle/ApiBundle/Resources/translations/validators.en.yaml
Outdated
Show resolved
Hide resolved
...ylius/Bundle/ApiBundle/spec/Validator/Constraints/ProductAvailableInChannelValidatorSpec.php
Outdated
Show resolved
Hide resolved
...ylius/Bundle/ApiBundle/spec/Validator/Constraints/ProductAvailableInChannelValidatorSpec.php
Outdated
Show resolved
Hide resolved
...ylius/Bundle/ApiBundle/spec/Validator/Constraints/ProductAvailableInChannelValidatorSpec.php
Outdated
Show resolved
Hide resolved
arti0090
force-pushed
the
adding-product-from-another-channel-bugfix
branch
from
5b9d4d6
to
8808712
Compare
arti0090
force-pushed
the
adding-product-from-another-channel-bugfix
branch
from
8808712
to
1834674
Compare
GSadee
approved these changes
May 7, 2021
|
Thank you, @arti0090! 🥇 |
lchrusciel
added a commit
that referenced
this pull request
May 10, 2021
This PR was merged into the 1.10-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes after upmerge #12609 | License | MIT <!-- - Bug fixes must be submitted against the 1.7 or 1.8 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 191a065 [API][PHPSpec] Fix validator after upmerge
lchrusciel
added a commit
that referenced
this pull request
May 10, 2021
This PR was merged into the 1.9 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.9 | Bug fix? | yes | New feature? | no | BC breaks? | no | Related tickets | continues #12609 | License | MIT Commits ------- 3b9cbb5 Change validation message to be consistent and move message to correct bundle f5f1645 [API] Adding inexistent product variant 1330777 [API] Merge validators for checking product variant during adding to cart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.