Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] sorting product by position in taxon #12621

Merged
merged 2 commits into from
May 12, 2021
Merged

[API] sorting product by position in taxon #12621

merged 2 commits into from
May 12, 2021

Conversation

AdamKasp
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
License MIT

@AdamKasp AdamKasp added the API APIs related issues and PRs. label May 10, 2021
@AdamKasp AdamKasp requested a review from a team as a code owner May 10, 2021 13:42
lchrusciel
lchrusciel reviewed May 10, 2021
View reviewed changes
src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/SortProductsByPositionInTaxon.php Outdated

$rootAlias = $queryBuilder->getRootAliases()[0];
$queryBuilder
->distinct()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you decided for distinct here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I added innerJoin to products taxons collection, and I want to avoid any duplication of record in response.

@AdamKasp AdamKasp force-pushed the sorting-product-by-position-in-taxon branch from 1023d2d to 957ebb7 Compare May 11, 2021 06:15
@AdamKasp AdamKasp force-pushed the sorting-product-by-position-in-taxon branch from 957ebb7 to 8ef2574 Compare May 11, 2021 06:52
@AdamKasp AdamKasp force-pushed the sorting-product-by-position-in-taxon branch from c27bb21 to 45a61db Compare May 12, 2021 07:15
@GSadee GSadee merged commit 2588620 into Sylius:master May 12, 2021
@GSadee
Copy link
Member

GSadee commented May 12, 2021

Thank you, Adam! 🥇

@AdamKasp AdamKasp deleted the sorting-product-by-position-in-taxon branch July 19, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel left review comments

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AdamKasp @GSadee @lchrusciel