[DOCS] API custom logic example #12627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arti0090
commented
May 12, 2021
arti0090
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
probot-autolabeler
bot
added
the
Documentation
arti0090
force-pushed
the
api-custom-logic-doc
branch
2 times, most recently
from
2f84962
to
155afb2
Compare
CoderMaggie
reviewed
May 13, 2021
AdamKasp
reviewed
May 13, 2021
|
And IMO you should also mention that this customization will work with API without any extra steps |
AdamKasp
reviewed
May 13, 2021
CoderMaggie
reviewed
May 13, 2021
GSadee
reviewed
May 14, 2021
Comment on lines
+157
to
+159
| "shippingState": "string", | ||
| "tokenValue": "CART_TOKEN", | ||
| "id": 123, |
There was a problem hiding this comment.
I wonder if we shouldn't show the whole response
GSadee
force-pushed
the
api-custom-logic-doc
branch
from
f6eb2c0
to
48c3bbb
Compare
GSadee
approved these changes
May 14, 2021
GSadee
force-pushed
the
api-custom-logic-doc
branch
from
48c3bbb
to
84bf8e2
Compare
|
Thank you, @arti0090! 🎉 |
GSadee
added a commit
that referenced
this pull request
May 14, 2021
…arti0090) This PR was merged into the 1.10-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | improves #12627 | License | MIT  The response in those endpoints are quite long and json codeblock does not let us use comments. I changed them to javascript (which does no change to UI/UX of docs) and added comments, so this would cut out confusion why responses are so short. Commits ------- 1b1d258 [DOCS] Change response codeblocks to be more clarified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.