[Bug] [Temporary solution] Comment out 2 behats steps for checking notifications #12633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
approved these changes
May 13, 2021
|
Thanks, @SirDomin! 🎉 |
AdamKasp
added a commit
that referenced
this pull request
Jul 21, 2021
This PR was merged into the 1.8 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | partially related to #12633 | License | MIT Commits ------- 88ce81d [GitHub Actions] Change command to restrict Symfony version 263c113 [Core] replace camelcase function cf705f5 Remove nonexistent u function 9a4fe75 Comment out 2 behat steps + fixes after symfony/security upgrade
NoResponseMate
added a commit
that referenced
this pull request
May 18, 2023
This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 <!-- see the comment below --> | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> | | Related tickets | #12633 | | License | MIT | <!-- - Bug fixes must be submitted against the 1.12 branch - Features and deprecations must be submitted against the 1.13 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Can be safely uncommented as #12633 is no more valid Commits ------- Uncomment editing customer profile steps
TheMilek
added a commit
that referenced
this pull request
Jun 26, 2023
This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 <!-- see the comment below --> | | Bug fix? | no | | New feature? | yes | | BC breaks? | no | | Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> | | License | MIT | <!-- - Bug fixes must be submitted against the 1.12 branch - Features and deprecations must be submitted against the 1.13 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Ref: #12633 I adjusted the step description to reflect its current state Commits ------- 2b1a243 [Scenarios] Add @api tag and change step implementation to reflect current app behaviour 7be12fd [Behat][UI] Remove unused step implementation 2677532 [ECS] Apply ecs fixes
GSadee
pushed a commit
to Sylius/SyliusCoreBundle
that referenced
this pull request
Aug 11, 2023
This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 <!-- see the comment below --> | | Bug fix? | no | | New feature? | yes | | BC breaks? | no | | Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> | | License | MIT | <!-- - Bug fixes must be submitted against the 1.12 branch - Features and deprecations must be submitted against the 1.13 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Ref: Sylius/Sylius#12633 I adjusted the step description to reflect its current state Commits ------- 2b1a243607a13fd53b9457c041b8064f8730d31e [Scenarios] Add @api tag and change step implementation to reflect current app behaviour 7be12fda6bce6389ecaf6efe9088f4c7e4ba5566 [Behat][UI] Remove unused step implementation 26775322f59e1d6c329b2dbe883330d2686c7c99 [ECS] Apply ecs fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until we are blocked by symfony security, we decided to remove steps checking for notifications after logging out.
The problem is: symfony/symfony@f012eee#diff-914ec544d4f7b26fda540aea3d7bc57cc5057d76bfb9ad72047d77739e3bb5a3R87
Before this change user still authorized so there was posibility to get session flash bags even after logging out, right now it deletes all session storage along with flashes, so there is no way to display them.