[API]Add inStock serialization to productVariant #12639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arti0090
commented
May 17, 2021
arti0090
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
arti0090
commented
May 17, 2021
| @@ -17,20 +18,25 @@ final class ProductVariantSerializer implements ContextAwareNormalizerInterface | |||
| /** @var NormalizerInterface */ | |||
| private $objectNormalizer; | |||
|
|
|||
| /** @var ProductVariantPriceCalculatorInterface */ | |||
| /** @var ProductVariantPricesCalculatorInterface */ | |||
There was a problem hiding this comment.
Changed this Interface, as It shows as deprecated.
arti0090
force-pushed
the
inStock-flag-in-product
branch
from
cf1c17b
to
7a905e8
Compare
AdamKasp
approved these changes
May 17, 2021
GSadee
reviewed
May 17, 2021
src/Sylius/Bundle/ApiBundle/Serializer/ProductVariantSerializer.php
Outdated
Show resolved
Hide resolved
GSadee
approved these changes
May 17, 2021
src/Sylius/Behat/Resources/config/suites/api/inventory/cart_inventory.yml
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Resources/translations/validators.en.yaml
Outdated
Show resolved
Hide resolved
arti0090
force-pushed
the
inStock-flag-in-product
branch
from
2c636cd
to
4571e19
Compare
AdamKasp
reviewed
May 17, 2021
| $this->putProductVariantToCart($productVariant, $tokenValue); | ||
|
|
||
| $response = $this->cartsClient->getLastResponse(); | ||
| Assert::same($response->getStatusCode(), 422); |
There was a problem hiding this comment.
can you check here validation message instead status code?
There was a problem hiding this comment.
I'd like to explain myself why I check status Code; the step is about 'unable to add it to the cart' and I dont think that this step cares why it happens (what validation message). This I think should be checked somewhere else, in add to cart validation behats 😃
|
Thanks, @arti0090! 🥇 |
GSadee
reviewed
May 17, 2021
lchrusciel
reviewed
May 18, 2021
| @@ -45,15 +51,17 @@ public function normalize($object, $format = null, array $context = []) | |||
| unset($data['price']); | |||
| } | |||
|
|
|||
| $data['inStock'] = $this->availabilityChecker->isStockAvailable($object); | |||
There was a problem hiding this comment.
Is it also shown in api reference in swagger?
GSadee
added a commit
that referenced
this pull request
May 24, 2021
This PR was merged into the 1.10-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes (missed thing) | BC breaks? | no | Deprecations? | no | Related tickets | Extends #12639 | License | MIT I forgot to add this to PR, forgive me sylius 🙏 Commits ------- de3a88d [API] Add missing inStock field to swagger 6798ade Changed to proper resource ProductVariant and fixed price
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.