[Api] Check stock sufficient while cart update #12654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tomanhez
commented
May 20, 2021
Tomanhez
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
Tomanhez
force-pushed
the
check-stock-sufficient-while-cart-update
branch
2 times, most recently
from
e916394
to
ba35be8
Compare
GSadee
reviewed
May 20, 2021
src/Sylius/Bundle/ApiBundle/Validator/Constraints/EligibleProductVariantToCart.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/Constraints/EligibleProductVariantToCartValidator.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/Constraints/EligibleProductVariantToCartValidator.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/Constraints/EligibleProductVariantToCartValidator.php
Outdated
Show resolved
Hide resolved
lchrusciel
reviewed
May 20, 2021
src/Sylius/Bundle/ApiBundle/Validator/Constraints/EligibleProductVariantToCartValidator.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/Constraints/EligibleProductVariantToCartValidator.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/Constraints/EligibleProductVariantToCartValidator.php
Outdated
Show resolved
Hide resolved
...us/Bundle/ApiBundle/spec/Validator/Constraints/EligibleProductVariantToCartValidatorSpec.php
Outdated
Show resolved
Hide resolved
lchrusciel
reviewed
May 21, 2021
src/Sylius/Bundle/ApiBundle/Validator/Constraints/EligibleProductVariantToCartValidator.php
Outdated
Show resolved
Hide resolved
Tomanhez
force-pushed
the
check-stock-sufficient-while-cart-update
branch
2 times, most recently
from
68ab3f6
to
6042a50
Compare
Tomanhez
force-pushed
the
check-stock-sufficient-while-cart-update
branch
3 times, most recently
from
80e817a
to
8750842
Compare
GSadee
reviewed
May 21, 2021
src/Sylius/Bundle/ApiBundle/Validator/Constraints/ChangingItemQuantityInCart.php
Outdated
Show resolved
Hide resolved
arti0090
reviewed
May 21, 2021
...lius/Bundle/ApiBundle/spec/Validator/Constraints/ChangingItemQuantityInCartValidatorSpec.php
Outdated
Show resolved
Hide resolved
Tomanhez
force-pushed
the
check-stock-sufficient-while-cart-update
branch
from
8750842
to
25fd430
Compare
GSadee
approved these changes
May 24, 2021
|
Thank you, Tomasz! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.