[API] Adding inexistent payment method #12657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arti0090
commented
May 20, 2021
arti0090
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
arti0090
force-pushed
the
api-inexistent-pay-method
branch
from
b8f42d2
to
1ba1e7c
Compare
AdamKasp
approved these changes
May 20, 2021
Zales0123
reviewed
May 20, 2021
features/checkout/paying_for_order/preventing_not_available_payment_method_selection.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/Constraints/ChoosePaymentMethodEligibilityValidator.php
Outdated
Show resolved
Hide resolved
.../Bundle/ApiBundle/spec/Validator/Constraints/ChoosePaymentMethodEligibilityValidatorSpec.php
Outdated
Show resolved
Hide resolved
.../Bundle/ApiBundle/spec/Validator/Constraints/ChoosePaymentMethodEligibilityValidatorSpec.php
Outdated
Show resolved
Hide resolved
.../Bundle/ApiBundle/spec/Validator/Constraints/ChoosePaymentMethodEligibilityValidatorSpec.php
Outdated
Show resolved
Hide resolved
.../Bundle/ApiBundle/spec/Validator/Constraints/ChoosePaymentMethodEligibilityValidatorSpec.php
Outdated
Show resolved
Hide resolved
.../Bundle/ApiBundle/spec/Validator/Constraints/ChoosePaymentMethodEligibilityValidatorSpec.php
Outdated
Show resolved
Hide resolved
arti0090
force-pushed
the
api-inexistent-pay-method
branch
from
2771ba5
to
7a15180
Compare
GSadee
reviewed
May 21, 2021
src/Sylius/Bundle/ApiBundle/Validator/Constraints/ChoosePaymentMethodEligibility.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/Constraints/ChoosePaymentMethodEligibility.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/Constraints/ChoosePaymentMethodEligibilityValidator.php
Outdated
Show resolved
Hide resolved
.../Bundle/ApiBundle/spec/Validator/Constraints/ChoosePaymentMethodEligibilityValidatorSpec.php
Outdated
Show resolved
Hide resolved
|
|
||
| function it_throws_an_exception_if_constraint_does_not_type_of_choose_payment_method_eligibility(): void | ||
| { | ||
| $constraint = new class() extends Constraint implements PaymentMethodCodeAwareInterface { |
There was a problem hiding this comment.
You can simplify this spec to sth like:
function it_throws_an_exception_if_constraint_is_not_an_instance_of_chosen_shipping_method_eligibility(): void
{
$this
->shouldThrow(\InvalidArgumentException::class)
->during('validate', [new ChoosePaymentMethod('code'), new class() extends Constraint {}])
;
}
.../Bundle/ApiBundle/spec/Validator/Constraints/ChoosePaymentMethodEligibilityValidatorSpec.php
Outdated
Show resolved
Hide resolved
arti0090
force-pushed
the
api-inexistent-pay-method
branch
from
97d40e7
to
5639dd7
Compare
arti0090
force-pushed
the
api-inexistent-pay-method
branch
from
5639dd7
to
b6d2e02
Compare
AdamKasp
approved these changes
May 24, 2021
| /** | ||
| * @When I try to select :paymentMethodCode payment method | ||
| */ | ||
| public function iTryToSelectPaymentMethod(string $paymentMethodCode): void |
There was a problem hiding this comment.
it is a duplication of method iChoosePaymentMethod can you use it instead of making a new one?
There was a problem hiding this comment.
It is not in 100%, the call is same (endpoint) but content is differently created see: $request->setContent(['paymentMethod' => $this->iriConverter->getItemIriFromResourceClass(PaymentMethod::class, ['code' => $paymentMethodCode])]);
lchrusciel
approved these changes
May 24, 2021
|
Thanks, @arti0090! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.