add validation on complete order #12658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AdamKasp
commented
May 20, 2021
AdamKasp
commented
| Q | A |
|---|---|
| Branch? | master |
| New feature? | yes |
| License | MIT |
Zales0123
reviewed
May 20, 2021
src/Sylius/Bundle/ApiBundle/Validator/Constraints/OrderProductInStockEligibilityValidator.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/Constraints/OrderProductInStockEligibilityValidator.php
Outdated
Show resolved
Hide resolved
.../Bundle/ApiBundle/spec/Validator/Constraints/OrderProductInStockEligibilityValidatorSpec.php
Outdated
Show resolved
Hide resolved
.../Bundle/ApiBundle/spec/Validator/Constraints/OrderProductInStockEligibilityValidatorSpec.php
Outdated
Show resolved
Hide resolved
.../Bundle/ApiBundle/spec/Validator/Constraints/OrderProductInStockEligibilityValidatorSpec.php
Outdated
Show resolved
Hide resolved
.../Bundle/ApiBundle/spec/Validator/Constraints/OrderProductInStockEligibilityValidatorSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/Constraints/OrderProductInStockEligibility.php
Outdated
Show resolved
Hide resolved
arti0090
reviewed
May 20, 2021
src/Sylius/Behat/Resources/config/suites/api/inventory/checkout_inventory.yaml
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Resources/config/suites/api/inventory/checkout_inventory.yaml
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Resources/config/suites/api/inventory/checkout_inventory.yaml
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/Constraints/OrderProductInStockEligibility.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/Constraints/OrderProductInStockEligibilityValidator.php
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
validation-placing-order-with-item-out-of-the-stock
branch
from
b2ed565
to
de26201
Compare
arti0090
reviewed
May 21, 2021
src/Sylius/Bundle/ApiBundle/Validator/Constraints/OrderProductInStockEligibilityValidator.php
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
validation-placing-order-with-item-out-of-the-stock
branch
from
de26201
to
e476f39
Compare
AdamKasp
force-pushed
the
validation-placing-order-with-item-out-of-the-stock
branch
from
e476f39
to
2e27e12
Compare
GSadee
reviewed
May 21, 2021
| Scenario: Placing an order with products that have sufficient quantity | ||
| Given I have added 3 products "Iron Maiden T-Shirt" to the cart | ||
| And I have proceeded selecting "Offline" payment method | ||
| And I proceed through checkout process |
There was a problem hiding this comment.
Suggested change
| And I proceed through checkout process | |
| When I proceed through checkout process |
but why did you change that step?
There was a problem hiding this comment.
I had a problem with addresses, in behats they were empty, and I get SM error, with this step, the scenario is still valid and checkout works as I expect.
src/Sylius/Bundle/ApiBundle/Validator/Constraints/OrderProductInStockEligibility.php
Outdated
Show resolved
Hide resolved
.../Bundle/ApiBundle/spec/Validator/Constraints/OrderProductInStockEligibilityValidatorSpec.php
Outdated
Show resolved
Hide resolved
.../Bundle/ApiBundle/spec/Validator/Constraints/OrderProductInStockEligibilityValidatorSpec.php
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
validation-placing-order-with-item-out-of-the-stock
branch
3 times, most recently
from
8e79960
to
6725511
Compare
AdamKasp
force-pushed
the
validation-placing-order-with-item-out-of-the-stock
branch
from
6725511
to
d5302d6
Compare
GSadee
approved these changes
May 24, 2021
|
Thanks, Adam! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.