[API] Add itemsTotal field to order resource #12661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arti0090
commented
May 21, 2021
arti0090
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
 |
GSadee
reviewed
May 21, 2021
features/cart/shopping_cart/seeing_detailed_information_about_cart.feature
Outdated
Show resolved
Hide resolved
AdamKasp
approved these changes
May 23, 2021
GSadee
reviewed
May 24, 2021
features/cart/shopping_cart/seeing_detailed_information_about_cart.feature
Show resolved
Hide resolved
arti0090
force-pushed
the
add-item-total-to-order
branch
2 times, most recently
from
74c129c
to
55f1073
Compare
Zales0123
reviewed
May 24, 2021
features/cart/shopping_cart/seeing_detailed_information_about_cart.feature
Outdated
Show resolved
Hide resolved
| Feature: Seeing detailed information of cart | ||
| In order to see detailed information of my cart | ||
| As a Visitor | ||
| I want to be able to see those information of my cart |
There was a problem hiding this comment.
In order to see (...) information, (...), I want to be able to see those information :( I believe the goal could be described better.
There was a problem hiding this comment.
I hope that newest changes with my limited humanistic possibilities would fulfill your desires 😄
features/cart/shopping_cart/seeing_detailed_information_about_cart.feature
Outdated
Show resolved
Hide resolved
| @@ -516,6 +516,17 @@ public function iCheckItemsOfMyCart(string $tokenValue): void | |||
| $this->cartsClient->executeCustomRequest($request); | |||
| } | |||
|
|
|||
| /** | |||
| * @Then /^my cart should have ("[^"]+") items total$/ | |||
There was a problem hiding this comment.
/^my cart should have ("[^"]+") items total$/ -> my cart should have :itemsTotal items total?
There was a problem hiding this comment.
I don't think this will work at first it will return (using 12.34 as example) $12.34 but i need 1234 as API returns int number. With ("[^"]+") I am getting the transformed value of 1234.
src/Sylius/Bundle/ApiBundle/Resources/config/serialization/Order.xml
Outdated
Show resolved
Hide resolved
AdamKasp
approved these changes
May 24, 2021
arti0090
force-pushed
the
add-item-total-to-order
branch
from
aa54eee
to
0e88a33
Compare
GSadee
approved these changes
May 24, 2021
|
Thank you, @arti0090! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.