Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Api] Customer see description of a product #12663

Merged
merged 3 commits into from
May 24, 2021
Merged

[Api] Customer see description of a product #12663

merged 3 commits into from
May 24, 2021

Conversation

Tomanhez
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

@Tomanhez Tomanhez requested a review from a team as a code owner May 24, 2021 09:31
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label May 24, 2021
Zales0123
Zales0123 reviewed May 24, 2021
View reviewed changes
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also serialize the description on ProductTranslation?

src/Sylius/Behat/Page/Shop/Product/ShowPageInterface.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Page/Shop/Product/ShowPage.php Show resolved Hide resolved
@GSadee GSadee merged commit 9851dbe into Sylius:master May 24, 2021
@GSadee
Copy link
Member

GSadee commented May 24, 2021

Thanks, Tomasz! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 left review comments

@GSadee GSadee GSadee approved these changes

@AdamKasp AdamKasp AdamKasp approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Tomanhez @GSadee @Zales0123 @AdamKasp