Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Validation to chose payment method #12665

Merged
merged 2 commits into from
May 26, 2021
Merged

Add Validation to chose payment method #12665

merged 2 commits into from
May 26, 2021

Conversation

AdamKasp
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
License MIT

@AdamKasp AdamKasp added the API APIs related issues and PRs. label May 24, 2021
@AdamKasp AdamKasp requested a review from a team as a code owner May 24, 2021 10:27
@AdamKasp AdamKasp force-pushed the validating-available-payment-methods branch from f6f0a1d to 9a3ddef Compare May 24, 2021 10:29
@Zales0123
Copy link
Member

@AdamKasp rebase needed 💃

@AdamKasp AdamKasp force-pushed the validating-available-payment-methods branch 4 times, most recently from fe4181b to 948bcfc Compare May 25, 2021 07:21
@AdamKasp AdamKasp force-pushed the validating-available-payment-methods branch from 948bcfc to 544177d Compare May 25, 2021 12:36
@AdamKasp AdamKasp force-pushed the validating-available-payment-methods branch 2 times, most recently from 3a88705 to 7a99432 Compare May 26, 2021 08:56
@AdamKasp AdamKasp force-pushed the validating-available-payment-methods branch from 7a99432 to 2678c2c Compare May 26, 2021 09:02
arti0090
arti0090 approved these changes May 26, 2021
View reviewed changes
src/Sylius/Behat/Context/Api/Shop/CheckoutContext.php

Assert::false(array_search($paymentMethodName, array_column($paymentMethods, 'name'), true));
Assert::true(
$this->responseChecker->hasViolationWithMessage($this->ordersClient->getLastResponse(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$this->responseChecker->hasViolationWithMessage($this->ordersClient->getLastResponse(),
$this->responseChecker->hasViolationWithMessage(
$this->ordersClient->getLastResponse(),

Well I might be wrong with this comment, but when checked some other ... hasViolationWithMessage... steps they are like this 😃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for me both options are fine, but it fit in a single line so I decided to left it in one line :)

@GSadee GSadee merged commit 17a5372 into Sylius:master May 26, 2021
@GSadee
Copy link
Member

GSadee commented May 26, 2021

Thanks, Adam! 🥇

@AdamKasp AdamKasp deleted the validating-available-payment-methods branch July 19, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil left review comments

@Zales0123 Zales0123 Zales0123 left review comments

@GSadee GSadee GSadee approved these changes

@arti0090 arti0090 arti0090 approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AdamKasp @Zales0123 @GSadee @pamil @arti0090