[Api] Tests adding incorrect county code to address order #12671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tomanhez
commented
May 25, 2021
Tomanhez
commented
| Q | A |
|---|---|
| Branch? | 1.9 |
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
Tomanhez
force-pushed
the
tests-for-address
branch
from
bca989c
to
7ad3be8
Compare
Tomanhez
changed the title
GSadee
reviewed
May 26, 2021
features/cart/shopping_cart/allowing_access_only_for_correctly_logged_in_users.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/Constraints/CorrectAddressOrder.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/Validator/Constraints/CorrectAddressOrderValidatorSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/Validator/Constraints/CorrectAddressOrderValidatorSpec.php
Outdated
Show resolved
Hide resolved
Tomanhez
force-pushed
the
tests-for-address
branch
3 times, most recently
from
3ba9c00
to
ebc19a9
Compare
Zales0123
reviewed
May 26, 2021
features/checkout/addressing_order/order_address_validation.feature
Outdated
Show resolved
Hide resolved
features/checkout/addressing_order/order_address_validation.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/Constraints/CorrectOrderAddressValidator.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/Constraints/CorrectOrderAddressValidator.php
Outdated
Show resolved
Hide resolved
| /** @var string|null $countryCode */ | ||
| $countryCode = $address->getCountryCode(); | ||
|
|
||
| if ($countryCode === null) { |
There was a problem hiding this comment.
I'm wondering, isn't it the case for the other validator 😄 We would then have two constraints e.g. CountrySpecified and CountryExisting? Seems as a better separation of responsibilities
There was a problem hiding this comment.
Its possible, but IMO it is just addressValidator. I can extract it to other services, but is it too much code to simple address validation? :D And we can add here next points for other address fields.
src/Sylius/Bundle/ApiBundle/spec/Validator/Constraints/CorrectOrderAddressValidatorSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/Validator/Constraints/CorrectOrderAddressValidatorSpec.php
Outdated
Show resolved
Hide resolved
Tomanhez
force-pushed
the
tests-for-address
branch
from
ebc19a9
to
07f3185
Compare
AdamKasp
approved these changes
May 27, 2021
GSadee
approved these changes
May 27, 2021
Comment on lines
+17
to
+18
| And the visitor try to specify the incorrect billing address as "Ankh Morpork", "Frost Alley", "90210", "United Russia" for "Jon Snow" | ||
| And the visitor complete the addressing step |
There was a problem hiding this comment.
These steps can be merged into one, the second one is not needed for API context
Comment on lines
+195
to
+197
| $addressType = 'billingAddress'; | ||
|
|
||
| $this->addAddress($addressType, $city, $street, $postcode, $customerName, $countryName); |
There was a problem hiding this comment.
Suggested change
| $addressType = 'billingAddress'; | |
| $this->addAddress($addressType, $city, $street, $postcode, $customerName, $countryName); | |
| $this->addAddress('billingAddress', $city, $street, $postcode, $customerName, $countryName); |
| } | ||
|
|
||
| /** | ||
| * @When /^the visitor try to specify the billing address without country as "([^"]+)", "([^"]+)", "([^"]+)" for "([^"]+)"$/ |
There was a problem hiding this comment.
You can name the arguments and then merge this method with the one above
Suggested change
| * @When /^the visitor try to specify the billing address without country as "([^"]+)", "([^"]+)", "([^"]+)" for "([^"]+)"$/ | |
| * @When the visitor try to specify the billing address without country as :city, :street, :postcode for :customerName |
| @@ -182,6 +182,33 @@ public function iSpecifyTheBillingAddressAs(AddressInterface $address): void | |||
| $this->fillAddress('billingAddress', $address); | |||
| } | |||
|
|
|||
| /** | |||
| * @When /^the visitor try to specify the incorrect billing address as "([^"]+)", "([^"]+)", "([^"]+)", "([^"]+)" for "([^"]+)"$/ | |||
There was a problem hiding this comment.
Suggested change
| * @When /^the visitor try to specify the incorrect billing address as "([^"]+)", "([^"]+)", "([^"]+)", "([^"]+)" for "([^"]+)"$/ | |
| * @When the visitor try to specify the incorrect billing address as :city, :street, :postcode, :countryName for :customerName |
|
Thank you, Tomasz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.