[API][Country] Initialize contract tests for api/v2 #12689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Jun 3, 2021
•
GSadee
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes? |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
GSadee
force-pushed
the
api-contract-tests-countries
branch
from
71c8ecf
to
8ec09d1
Compare
GSadee
force-pushed
the
api-contract-tests-countries
branch
from
8ec09d1
to
7849a0b
Compare
Zales0123
approved these changes
Jun 8, 2021
| use Sylius\Tests\Api\JsonApiTestCase; | ||
| use Symfony\Component\HttpFoundation\Response; | ||
|
|
||
| final class GetCountriesTest extends JsonApiTestCase |
There was a problem hiding this comment.
I'm wondering, do we want to have tests for different operations for the same resource separated between classes or functions in one class? If the latter, I would name it CountriesTest and name the function it_returns_countries_list/it_provides_countries_list or something like it 🖖
|
Thanks, Grzegorz! 🎉 |
lchrusciel
added a commit
that referenced
this pull request
Jun 8, 2021
…payment methods endpoint (GSadee) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes? | BC breaks? | no | Deprecations? | no | Related tickets | based on #12689 | License | MIT Commits ------- 36eb5dd [API][PaymentMethod] Add contract test for available payment methods endpoint 01b1769 [API] Fix problem with getting command bus from container in api test case b094954 [API] Fix CachedRouteNameResolverTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.