[API] Use serializer instead of custom view for shipping methods #12713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Jun 17, 2021
•
GSadee
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | replaces #12392 |
| License | MIT |
GSadee
added
Enhancement
probot-autolabeler
bot
added
the
Maintenance
This was referenced Jun 17, 2021
Zales0123
reviewed
Jun 17, 2021
GSadee
force-pushed
the
api-use-serializer-instead-of-custom-view-for-shipping-methods
branch
2 times, most recently
from
6a13d90
to
9df6d86
Compare
… getting shipping methods
GSadee
force-pushed
the
api-use-serializer-instead-of-custom-view-for-shipping-methods
branch
from
4e13ab0
to
e914795
Compare
arti0090
reviewed
Jun 21, 2021
src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/ShippingMethod.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Swagger/ShippingMethodDocumentationNormalizer.php
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Swagger/ShippingMethodDocumentationNormalizer.php
Outdated
Show resolved
Hide resolved
Zales0123
approved these changes
Jun 21, 2021
|
Thank you, Grzegorz! 🎉 |
GSadee
deleted the
api-use-serializer-instead-of-custom-view-for-shipping-methods
branch
AdamKasp
added a commit
that referenced
this pull request
Jun 22, 2021
…shipping methods endpoint (GSadee) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | based on #12713 | License | MIT Commits ------- 175ca05 [API] Change names of API contract tests dedad00 [API][ShippingMethod] Add contract test for available shipping methods endpoint
lchrusciel
reviewed
Jun 22, 2021
| /** @experimental */ | ||
| final class ShippingMethodNormalizer implements ContextAwareNormalizerInterface, NormalizerAwareInterface | ||
| { | ||
| use NormalizerAwareTrait; |
There was a problem hiding this comment.
IIRC this trait makes it harder to decorate service in the end app. Do you think we could use regular DI for normalization logic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.