[API][ShippingMethod] Add contract test for available shipping methods endpoint #12716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Jun 17, 2021
GSadee
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | based on #12713 |
| License | MIT |
probot-autolabeler
bot
added
the
Maintenance
GSadee
force-pushed
the
api-shop-shipping-methods-contract-test
branch
from
120da15
to
55fa3c8
Compare
pamil
reviewed
Jun 17, 2021
GSadee
force-pushed
the
api-shop-shipping-methods-contract-test
branch
2 times, most recently
from
5193a32
to
d17f037
Compare
AdamKasp
reviewed
Jun 18, 2021
src/Sylius/Bundle/ApiBundle/Serializer/ShippingMethodNormalizer.php
Outdated
Show resolved
Hide resolved
AdamKasp
approved these changes
Jun 18, 2021
GSadee
force-pushed
the
api-shop-shipping-methods-contract-test
branch
from
d17f037
to
bffc4c6
Compare
SirDomin
reviewed
Jun 18, 2021
src/Sylius/Bundle/ApiBundle/spec/Serializer/ShippingMethodNormalizerSpec.php
Outdated
Show resolved
Hide resolved
GSadee
force-pushed
the
api-shop-shipping-methods-contract-test
branch
from
bffc4c6
to
6ef6761
Compare
@SirDomin these files are not empty, just no changes were made to them except the filename |
Zales0123
approved these changes
Jun 21, 2021
| ; | ||
| } | ||
|
|
||
| private function isNotAdminGetOperation(array $context): bool |
There was a problem hiding this comment.
The second normalizer where we use such a function, maybe it would worth to extract it into some separate service in the future 🖖 💃
GSadee
force-pushed
the
api-shop-shipping-methods-contract-test
branch
2 times, most recently
from
45978e5
to
f979c4d
Compare
GSadee
force-pushed
the
api-shop-shipping-methods-contract-test
branch
from
f979c4d
to
dedad00
Compare
arti0090
approved these changes
Jun 22, 2021
|
Thank you, Grzegorz! 🥇 |
lchrusciel
reviewed
Jun 22, 2021
| { | ||
| "@id": "\/api\/v2\/shop\/shipping-methods\/UPS", | ||
| "@type": "ShippingMethod", | ||
| "id": @integer@, |
There was a problem hiding this comment.
Suggested change
| "id": @integer@, | |
| "id": "@integer@", |
From the matcher's point of view, such a notation would be equal to the current one. The change is, that GitHub nor phpstorm would complain about invalid json shema. On the other hand, it would look like there is a string at the integer field... Just a proposal. It is worth it to put all matchers into ", but I would love to hear your opinion about it as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.