[API] Add contract test to admin ProductVariant #12745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arti0090
commented
Jun 23, 2021
arti0090
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
probot-autolabeler
bot
added
API
arti0090
force-pushed
the
productVariant-serialization
branch
from
f41f401
to
2570d24
Compare
Zales0123
reviewed
Jun 23, 2021
src/Sylius/Bundle/ApiBundle/spec/Serializer/ProductVariantNormalizerSpec.php
Outdated
Show resolved
Hide resolved
arti0090
force-pushed
the
productVariant-serialization
branch
from
2570d24
to
201d7d5
Compare
Zales0123
approved these changes
Jun 23, 2021
src/Sylius/Bundle/ApiBundle/spec/Serializer/ProductVariantNormalizerSpec.php
Outdated
Show resolved
Hide resolved
SirDomin
approved these changes
Jun 23, 2021
GSadee
reviewed
Jun 24, 2021
src/Sylius/Bundle/ApiBundle/Serializer/ProductVariantNormalizer.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/Serializer/ProductVariantNormalizerSpec.php
Outdated
Show resolved
Hide resolved
tests/Api/Responses/Expected/admin/get_product_variant_response.json
Outdated
Show resolved
Hide resolved
arti0090
force-pushed
the
productVariant-serialization
branch
2 times, most recently
from
68efdd6
to
3e12582
Compare
arti0090
force-pushed
the
productVariant-serialization
branch
from
3e12582
to
2dcc1b0
Compare
Zales0123
approved these changes
Jun 24, 2021
lchrusciel
approved these changes
Jun 24, 2021
| public function __construct( | ||
| ProductVariantPricesCalculatorInterface $priceCalculator, | ||
| ChannelContextInterface $channelContext, | ||
| AvailabilityCheckerInterface $availabilityChecker | ||
| AvailabilityCheckerInterface $availabilityChecker, | ||
| SectionProviderInterface $uriBasedSectionContext |
There was a problem hiding this comment.
Suggested change
| SectionProviderInterface $uriBasedSectionContext | |
| SectionProviderInterface $sectionContext |
| final class ProductVariantTest extends JsonApiTestCase | ||
| { | ||
| /** @test */ | ||
| public function it_denies_access_to_a_products_list_for_not_authenticated_user(): void |
There was a problem hiding this comment.
Suggested change
| public function it_denies_access_to_a_products_list_for_not_authenticated_user(): void | |
| public function it_denies_access_to_an_admin_products_list_for_not_authenticated_user(): void |
| } | ||
|
|
||
| /** @test */ | ||
| public function it_gets_all_product_variants(): void |
There was a problem hiding this comment.
Suggested change
| public function it_gets_all_product_variants(): void | |
| public function it_gets_all_product_variants_for_authorized_administrator(): void |
|
Thanks, @arti0090! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.