[API] change error to violation #12749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SirDomin
commented
Jun 24, 2021
SirDomin
commented
| Q | A |
|---|---|
| Branch? | 1.10 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | #12746 |
| License | MIT |
SirDomin
added
the
Enhancement
lchrusciel
approved these changes
Jun 24, 2021
SirDomin
force-pushed
the
change-error-to-validation-select-shipping
branch
from
1dc5fe2
to
7be565f
Compare
Zales0123
approved these changes
Jun 24, 2021
| @@ -106,6 +116,11 @@ function it_does_not_add_violation_if_chosen_shipping_method_matches_supported_m | |||
|
|
|||
| $shipmentRepository->find('123')->willReturn($shipment); | |||
|
|
|||
|
|
|||
|
Thank you, @SirDomin! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.