Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Refactor converting arguments of commands from IRIs to identifiers #12769

Merged
merged 9 commits into from Jul 22, 2021
Merged

[API] Refactor converting arguments of commands from IRIs to identifiers #12769

merged 9 commits into from Jul 22, 2021

Conversation

Tomanhez
Copy link
Contributor

@Tomanhez Tomanhez commented Jul 1, 2021 •
edited by GSadee

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets #12487
License MIT

@Tomanhez Tomanhez added Feature New feature proposals. API APIs related issues and PRs. labels Jul 1, 2021
@Tomanhez Tomanhez requested a review from a team as a code owner July 1, 2021 21:14
@Tomanhez Tomanhez force-pushed the command-item-iri-argument-to-identifier-map-rework branch from 0adf12d to a81f6c0 Compare July 1, 2021 21:19
@Tomanhez Tomanhez force-pushed the command-item-iri-argument-to-identifier-map-rework branch 3 times, most recently from 4da7547 to b91662f Compare July 2, 2021 07:28
@Tomanhez Tomanhez force-pushed the command-item-iri-argument-to-identifier-map-rework branch 3 times, most recently from 3d1d0b5 to 29df650 Compare July 6, 2021 07:26
@AdamKasp AdamKasp changed the title [Api][PoC] Automate CommandFieldItemIriToIdentifierDenormalizer [Api] Automate CommandFieldItemIriToIdentifierDenormalizer Jul 14, 2021
@AdamKasp AdamKasp force-pushed the command-item-iri-argument-to-identifier-map-rework branch 4 times, most recently from c98f6a1 to 3cc47a7 Compare July 19, 2021 06:00
@GSadee GSadee force-pushed the command-item-iri-argument-to-identifier-map-rework branch from 3cc47a7 to 5f45010 Compare July 21, 2021 11:46
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Jul 21, 2021
@GSadee GSadee changed the title [Api] Automate CommandFieldItemIriToIdentifierDenormalizer [API] Refactor converting arguments of commands from IRIs to identifiers Jul 21, 2021
@GSadee GSadee dismissed their stale review July 21, 2021 12:03

Changes have been applied

@GSadee GSadee force-pushed the command-item-iri-argument-to-identifier-map-rework branch 2 times, most recently from 92eabae to 7aa9b4d Compare July 21, 2021 13:03
@GSadee GSadee force-pushed the command-item-iri-argument-to-identifier-map-rework branch from 0c504cd to a87ef15 Compare July 22, 2021 08:48
lchrusciel
lchrusciel approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we shouldn't

src/Sylius/Bundle/ApiBundle/Command/Checkout/ChooseShippingMethod.php
use Sylius\Bundle\ApiBundle\Command\OrderTokenValueAwareInterface;
use Sylius\Bundle\ApiBundle\Command\SubresourceIdAwareInterface;

/** @experimental */
class ChooseShippingMethod implements OrderTokenValueAwareInterface, SubresourceIdAwareInterface
class ChooseShippingMethod implements OrderTokenValueAwareInterface, SubresourceIdAwareInterface, IriToIdentifierConversionAwareInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if both SubresourceIdAwareInterface and IriToIdentifierConversionAwareInterface inferfaces shouldn't be extracted to one. Same for most of usage of IriToIdentifierConversionAwareInterface

@AdamKasp AdamKasp merged commit 30d7b98 into Sylius:master Jul 22, 2021
@AdamKasp
Copy link
Contributor

AdamKasp commented Jul 22, 2021 •
edited

Thanks, Tomasz and Grzegorz! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stloyd stloyd stloyd left review comments

@lchrusciel lchrusciel lchrusciel approved these changes

@SirDomin SirDomin SirDomin approved these changes

@AdamKasp AdamKasp AdamKasp approved these changes

@GSadee GSadee GSadee left review comments

Assignees
No one assigned
Labels
API APIs related issues and PRs. Feature New feature proposals. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Tomanhez @AdamKasp @stloyd @GSadee @lchrusciel @SirDomin