Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Turn on/off api endpoints with parameter #12771

Merged
merged 9 commits into from
Jul 7, 2021

Conversation

SirDomin
Copy link
Contributor

@SirDomin SirDomin commented Jul 2, 2021

Q A
Branch? 1.8
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
License MIT

@SirDomin SirDomin requested a review from a team as a code owner July 2, 2021 07:00
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Jul 2, 2021
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Jul 2, 2021
@SirDomin SirDomin force-pushed the api-as-opt branch 5 times, most recently from bcd8cfa to 1306cf3 Compare July 2, 2021 09:45
@SirDomin SirDomin force-pushed the api-as-opt branch 3 times, most recently from fd2397c to a6947e4 Compare July 4, 2021 21:10
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Jul 5, 2021
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it to 1.8

@lchrusciel lchrusciel changed the base branch from 1.9 to 1.8 July 6, 2021 10:36
@lchrusciel lchrusciel changed the base branch from 1.8 to 1.9 July 6, 2021 10:37
@lchrusciel lchrusciel changed the base branch from 1.9 to 1.8 July 6, 2021 10:51
@lchrusciel lchrusciel closed this Jul 6, 2021
@lchrusciel lchrusciel reopened this Jul 6, 2021
@SirDomin SirDomin force-pushed the api-as-opt branch 3 times, most recently from 681a044 to 022b630 Compare July 6, 2021 11:52
@SirDomin SirDomin force-pushed the api-as-opt branch 2 times, most recently from 63371ad to 8cb3223 Compare July 7, 2021 10:00
@SirDomin SirDomin changed the base branch from 1.8 to 1.9 July 7, 2021 10:00
@SirDomin SirDomin force-pushed the api-as-opt branch 4 times, most recently from 78bffb2 to f454dc7 Compare July 7, 2021 10:52
@AdamKasp AdamKasp merged commit 4ef47e6 into Sylius:1.9 Jul 7, 2021
@AdamKasp
Copy link
Contributor

AdamKasp commented Jul 7, 2021

Thank you, @SirDomin! 🥇

@papatails
Copy link

And this would be me . Just saying thank you I’ve tried a lot of things and just to avail you broke them down. Now what can I do on the owner’s end. I’ve figured out when someone said just go inside and look around. I did in may 2020 life hasn’t been the same, I’m still trying and there still here but I shall conquer this with help from people like you.

SirDomin added a commit that referenced this pull request Jul 8, 2021
This PR was merged into the 1.9 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.9
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | fixes #12771 
| License         | MIT



Commits
-------

91e84e4 [API] Disable API by default
2ecd69b [API] Move note about disabled API to proper section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs. Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants