[API][FIX] Remove code attribute of OrderItem in API serialization #12773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @lchrusciel |
|
Ping @Sylius/core-team ;) |
|
facing the same issue, also found that same issue in the SyliusPlus in this file |
AdamKasp
approved these changes
Jul 19, 2022
Zales0123
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
👍 but I wonder, shouldn't it be merged into 1.11 (as it's definitely a bug fix). And we definitely need to add a note into the UPGRADE file (in theory one could already have a code property added in the OrderItem entity and count on this serialization configuration 🔥)
lchrusciel
force-pushed
the
fix-api-orderitem-code
branch
from
a183bb7
to
c4dece9
Compare
probot-autolabeler
bot
added
the
Maintenance
|
Thanks, @oallain and @lchrusciel! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrderItem has no attribut
codebut this attribute is in Serialisation configuration.This throw an error when we Normalize Object.