[API] Add Product Image type to responses #12774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arti0090
commented
Jul 3, 2021
arti0090
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
AdamKasp
approved these changes
Jul 4, 2021
AdamKasp
reviewed
Jul 4, 2021
Comment on lines
+17
to
+18
| <group>admin:product:read</group> | ||
| <group>shop:product:read</group> |
There was a problem hiding this comment.
why do you add this serialization also on product response?
GSadee
approved these changes
Jul 5, 2021
| use Sylius\Tests\Api\JsonApiTestCase; | ||
| use Symfony\Component\HttpFoundation\Response; | ||
|
|
||
| final class ProductImageTest extends JsonApiTestCase |
There was a problem hiding this comment.
Suggested change
| final class ProductImageTest extends JsonApiTestCase | |
| final class ProductImagesTest extends JsonApiTestCase |
| { | ||
| $fixtures = $this->loadFixturesFromFiles(['product_image.yaml', 'authentication/api_administrator.yaml']); | ||
| /** @var ProductImageInterface $productImage */ | ||
| $productImage = $fixtures["product_thumbnail"]; |
There was a problem hiding this comment.
Suggested change
| $productImage = $fixtures["product_thumbnail"]; | |
| $productImage = $fixtures['product_thumbnail']; |
| use Sylius\Tests\Api\JsonApiTestCase; | ||
| use Symfony\Component\HttpFoundation\Response; | ||
|
|
||
| final class ProductImageTest extends JsonApiTestCase |
There was a problem hiding this comment.
Suggested change
| final class ProductImageTest extends JsonApiTestCase | |
| final class ProductImagesTest extends JsonApiTestCase |
|
Thank you, @arti0090! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.