Add "enabled" property to API serialization #12781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nek-
changed the title
lchrusciel
approved these changes
Dec 9, 2022
|
tests to extend can be found here: https://github.com/Sylius/Sylius/blob/1.13/tests/Api/Admin/ProductVariantsTest.php. This flag needs to be set in fixtures and exposed in json samples. Such tests have to be done for each resource that is tackled here. What is more, rebase is needed |
Nek-
force-pushed
the
feature/add-missing-copyright
branch
from
39c31f4
to
429c6b0
Compare
|
@lchrusciel updated 😊 |
|
Hi @Nek-! |
Nek-
force-pushed
the
feature/add-missing-copyright
branch
from
429c6b0
to
729a617
Compare
|
@jakubtobiasz done! |
|
Hi @Nek-! |
Nek-
force-pushed
the
feature/add-missing-copyright
branch
2 times, most recently
from
b324640
to
a9e20ef
Compare
|
@jakubtobiasz Sorry for the delay, it should be fine now. |
Rafikooo
reviewed
Mar 17, 2023
src/Sylius/Bundle/ApiBundle/Resources/config/serialization/ProductVariant.xml
Show resolved
Hide resolved
Knowing if an item is enable or not is a critical information while
querying the API in admin mode. This feature ("enabled") has been
introduced in Sylius 1.8 and is exposed thanks to this commit.
Nek-
force-pushed
the
feature/add-missing-copyright
branch
from
a9e20ef
to
53621c9
Compare
jakubtobiasz
approved these changes
Mar 22, 2023
NoResponseMate
approved these changes
Mar 22, 2023
|
Thank you, @Nek-! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggestion/feature. But it really makes sense to expose if an item is enabled or not in admin serialization, it's actually a piece of super-critical information for admin data results.
Sorry for the noise of fixing also copyright but my brain was not happy it was not heterogeneous. x) It's split into 2 proper commits if you want to review with ease.
Happy coding guys.