[API] Remove customer and serialize posted address #12785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arti0090
commented
Jul 6, 2021
arti0090
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
probot-autolabeler
bot
added
API
arti0090
force-pushed
the
address-creating-serialization
branch
2 times, most recently
from
b7a505d
to
30aaa0c
Compare
AdamKasp
reviewed
Jul 6, 2021
arti0090
force-pushed
the
address-creating-serialization
branch
from
30aaa0c
to
b95a232
Compare
arti0090
force-pushed
the
address-creating-serialization
branch
from
b95a232
to
a19977e
Compare
GSadee
approved these changes
Jul 7, 2021
Comment on lines
+2
to
+11
| "firstName":"TEST", | ||
| "lastName":"TEST", | ||
| "phoneNumber":"666111333", | ||
| "company":"Potato Corp.", | ||
| "countryCode":"US", | ||
| "provinceCode":null, | ||
| "provinceName":null, | ||
| "street":"Top secret", | ||
| "city":"Nebraska", | ||
| "postcode":"12343" |
| @@ -0,0 +1,16 @@ | |||
| Sylius\Component\Core\Model\ShopUser: | |||
| user_{Oliver}: | |||
There was a problem hiding this comment.
Suggested change
| user_{Oliver}: | |
| shop_user_{oliver}: |
| usernameCanonical: "<current()>\\@doe.com" | ||
|
|
||
| Sylius\Component\Core\Model\Customer: | ||
| customer_{Oliver}: |
There was a problem hiding this comment.
Suggested change
| customer_{Oliver}: | |
| customer_{oliver}: |
|
|
||
| $response = $this->client->getResponse(); | ||
|
|
||
| $this->assertResponse($response, 'shop/post_addresses_response', Response::HTTP_CREATED); |
There was a problem hiding this comment.
Suggested change
| $this->assertResponse($response, 'shop/post_addresses_response', Response::HTTP_CREATED); | |
| $this->assertResponse($response, 'shop/create_address_response', Response::HTTP_CREATED); |
|
Thank you, @arti0090! 🎉 |
GSadee
added a commit
that referenced
this pull request
Jul 12, 2021
…ing post on address (arti0090) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes for #12785 | License | MIT Commits ------- 888087e [ENH][API] Fixing naming issues after PR for serializing post on address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.