New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable API by default in dev environment #12804
Conversation
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 馃憤 |
89a6c9c
to
0d53489
Compare
In overall this is huge BC break to disabled in minor version something that was enabled before by default... cause as developer you don't expect to do update, have code working in dev env go to production & get fatal errors or 404s... |
Thank you, Mateusz! 馃 |
@stloyd in general, you're totally right 馃枛 but because this new API is still in an experimental phase, a much bigger threat is to make it enabled by default and potentially introduce some security problems to the Sylius applications code 馃殌 |
This PR was merged into the 1.10 branch. Discussion ---------- For easier development of testing of the new application 馃枛 It was already done for Sylius/Sylius [a long time ago](Sylius/Sylius#12804). Commits ------- 634ecdf Enable Sylius API in dev by default
This PR was merged into the 1.10 branch. Discussion ---------- For easier development of testing of the new application 馃枛 It was already done for Sylius/Sylius [a long time ago](Sylius/Sylius#12804). Commits ------- 634ecdf858a68c5bbecf53eff79272e78707746e Enable Sylius API in dev by default
I believe it would be useful for the development 馃枛 Without it if I want to change something in the API I need to change the parameter and pray to not forget to remove it before committing 馃檹 馃帀