Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] 1.8 api as opt #12819

Merged
merged 10 commits into from Jul 22, 2021
Merged

[API] 1.8 api as opt #12819

merged 10 commits into from Jul 22, 2021

Conversation

SirDomin
Copy link
Contributor

Q A
Branch? 1.8
Bug fix? no
New feature? no
BC breaks? yes
Deprecations?
Related tickets
License MIT

@SirDomin SirDomin requested a review from a team as a code owner July 21, 2021 06:29
@probot-autolabeler probot-autolabeler bot added API APIs related issues and PRs. Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc. labels Jul 21, 2021
@SirDomin SirDomin force-pushed the 1.8-api-as-opt branch 4 times, most recently from 3ec9177 to 76fd821 Compare July 22, 2021 07:05
@AdamKasp AdamKasp merged commit c8e7702 into Sylius:1.8 Jul 22, 2021
@AdamKasp
Copy link
Contributor

Thank you, @SirDomin! 🥇

GSadee
GSadee reviewed Jul 23, 2021
View reviewed changes
src/Sylius/Bundle/ApiBundle/DependencyInjection/Configuration.php
$rootNode
->children()
->booleanNode('enabled')
->defaultTrue()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaultFalse()

@GSadee GSadee mentioned this pull request Jul 23, 2021
Merged
AdamKasp added a commit that referenced this pull request Jul 23, 2021
@AdamKasp
bug #12833 [API] Disable API by default (GSadee)
11f088f 
This PR was merged into the 1.8 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.8
| Bug fix?        | yes?
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | fixes #12819 
| License         | MIT


Commits
-------

dfeffe1 [API] Disable API by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee left review comments

@lchrusciel lchrusciel lchrusciel approved these changes

@AdamKasp AdamKasp AdamKasp approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SirDomin @AdamKasp @GSadee @lchrusciel