Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Allow creation of commands with no arguments with a default value #12823

Merged
merged 1 commit into from Jul 21, 2021
Merged

[API] Allow creation of commands with no arguments with a default value #12823

merged 1 commit into from Jul 21, 2021

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Jul 21, 2021

Q A
Branch? 1.9
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #12811
License MIT

Fixes tests on 1.10 and master branches, where we test RegisterShopUser that has new not nullable argument with a default value.

Failing test: https://github.com/Sylius/Sylius/runs/3122767036?check_suite_focus=true#step:18:75

@GSadee GSadee added the Bug Confirmed bugs or bugfixes. label Jul 21, 2021
@GSadee GSadee requested a review from a team as a code owner July 21, 2021 12:32
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Jul 21, 2021
@Zales0123 Zales0123 merged commit bf23a70 into Sylius:1.9 Jul 21, 2021
@Zales0123
Copy link
Member

Thanks, Grzegorz! 🥇

@GSadee GSadee deleted the api-arguments-with-default-value branch July 21, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GSadee @Zales0123