Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Fixed logo customization #12824

Merged

Conversation

maciek-wozniak
Copy link

@maciek-wozniak maciek-wozniak commented Jul 21, 2021

Q A
Branch? 1.9
Bug fix? no
New feature? no
BC breaks? no
Deprecations?
Related tickets
License MIT

Fixed path to logo template file

@maciek-wozniak maciek-wozniak requested a review from a team as a code owner July 21, 2021 14:01
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Jul 21, 2021
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, we could even mention, it can be customized by changing the configuration of sylius.shop.layout.header.grid UI event, but still, this change definitely fixes the bug :)

docs/getting-started-with-sylius/shop-customizations.rst Outdated Show resolved Hide resolved
@Zales0123 Zales0123 changed the base branch from 1.10 to 1.9 July 23, 2021 07:43
@Zales0123
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "docs/fixing-logo-customization" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@Zales0123 Zales0123 force-pushed the docs/fixing-logo-customization branch from f0816ff to a50af87 Compare July 23, 2021 07:44
@CoderMaggie CoderMaggie merged commit 1f6b320 into Sylius:1.9 Sep 9, 2021
@CoderMaggie
Copy link
Member

CoderMaggie commented Sep 9, 2021

Thanks, @maciek-wozniak! 🎉 Congrats on your first contribution to Sylius 💪🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants