[API] Unification of filtration namespaces #12846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
added
Enhancement
probot-autolabeler
bot
added
the
Maintenance
lchrusciel
force-pushed
the
filters-common-namespace
branch
from
081935a
to
5120154
Compare
lchrusciel
force-pushed
the
filters-common-namespace
branch
from
5120154
to
7fcc65c
Compare
GSadee
approved these changes
Jul 27, 2021
|
Thanks, Łukasz! 🎉 |
arti0090
pushed a commit
to arti0090/Sylius
that referenced
this pull request
Jul 28, 2021
…rusciel) This PR was merged into the 1.11-dev branch. labels: bc-break Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | no | Related tickets | | License | MIT All class folders are kept in the singular form. What is more, we already have one filter in the `Sylius\Bundle\ApiBundle\Doctrine\Filter` namespace <!-- - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 7fcc65c [API] Unification of filtration namespaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All class folders are kept in the singular form. What is more, we already have one filter in the
Sylius\Bundle\ApiBundle\Doctrine\Filternamespace