[API]Product image handling #12847
Merged
[API]Product image handling #12847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arti0090
commented
Jul 28, 2021
arti0090
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
arti0090
force-pushed
the
product-image-handling
branch
from
c9c424b
to
0c39a7b
Compare
probot-autolabeler
bot
added
the
Maintenance
arti0090
force-pushed
the
product-image-handling
branch
3 times, most recently
from
975c850
to
ba52863
Compare
arti0090
force-pushed
the
product-image-handling
branch
from
ba52863
to
be44dda
Compare
probot-autolabeler
bot
added
the
Maintenance
arti0090
force-pushed
the
product-image-handling
branch
4 times, most recently
from
eac1b75
to
c141d1c
Compare
arti0090
force-pushed
the
product-image-handling
branch
6 times, most recently
from
822230c
to
bcf281c
Compare
arti0090
force-pushed
the
product-image-handling
branch
from
bcf281c
to
17afb9f
Compare
GSadee
approved these changes
Jul 29, 2021
lchrusciel
reviewed
Jul 29, 2021
| @@ -33,6 +33,11 @@ public function getConfigTreeBuilder(): TreeBuilder | |||
| ->defaultFalse() | |||
| ->end() | |||
| ->end() | |||
| ->children() | |||
| ->variableNode('product_image_prefix') | |||
| ->defaultValue('media/image') | |||
There was a problem hiding this comment.
I'm fine with defining this value as a parameter, however we should at least use another parameter, that will be used here as well:
But once we will introduce the parameter there, I'm not sure we need it. Up to you.
src/Sylius/Bundle/ApiBundle/Serializer/ProductImageNormalizer.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Serializer/ProductImageNormalizer.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/Serializer/ProductImageNormalizerSpec.php
Outdated
Show resolved
Hide resolved
arti0090
force-pushed
the
product-image-handling
branch
2 times, most recently
from
c5a9a77
to
db98dd4
Compare
GSadee
reviewed
Jul 30, 2021
UPGRADE-API-1.11.md
Outdated
| "id": "123", | ||
| "type": "thumbnail", | ||
| "path": "uo/product.jpg", | ||
| + "media_path": "/media/image/uo/product.jpg" |
There was a problem hiding this comment.
If I see correctly, there is no more media_path, you are updating path field
There was a problem hiding this comment.
I have changed it a little now :)
src/Sylius/Bundle/ApiBundle/Serializer/ProductImageNormalizer.php
Outdated
Show resolved
Hide resolved
arti0090
force-pushed
the
product-image-handling
branch
from
db98dd4
to
b464218
Compare
arti0090
force-pushed
the
product-image-handling
branch
from
b464218
to
201e900
Compare
GSadee
approved these changes
Jul 30, 2021
|
Thank you, @arti0090! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.