Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Order] Protect processors from execution if the order is in a state different than cart #12851

Merged
merged 2 commits into from Aug 2, 2021
Merged

[Order] Protect processors from execution if the order is in a state different than cart #12851

merged 2 commits into from Aug 2, 2021

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Aug 2, 2021

Q A
Branch? master
Bug fix? no
New feature? no?
BC breaks? no
Deprecations? no
Related tickets
License MIT

@GSadee GSadee added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Aug 2, 2021
@GSadee GSadee requested a review from a team as a code owner August 2, 2021 05:07
@GSadee GSadee changed the title [Order] Protect processors from execution if the order is in a state different then cart [Order] Protect processors from execution if the order is in a state different than cart Aug 2, 2021
Tomanhez
Tomanhez approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@Tomanhez Tomanhez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should to add short description in docs about order individual processor's limitations and Composit without limitations?

@SirDomin SirDomin merged commit 5bdf622 into Sylius:master Aug 2, 2021
@SirDomin
Copy link
Contributor

SirDomin commented Aug 2, 2021

Thank you, Grzegorz! 🥇

@GSadee GSadee deleted the protect-order-processors branch August 2, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirDomin SirDomin SirDomin approved these changes

@arti0090 arti0090 arti0090 approved these changes

@Tomanhez Tomanhez Tomanhez approved these changes

Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GSadee @SirDomin @arti0090 @Tomanhez