[API] Add liip image filters to API #12862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arti0090
force-pushed
the
product-image-querrying
branch
from
bb0ac72
to
8627964
Compare
stloyd
reviewed
Aug 5, 2021
src/Sylius/Bundle/ApiBundle/Provider/LiipProductImageFilterProvider.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Swagger/ProductImageDocumentationNormalizer.php
Outdated
Show resolved
Hide resolved
arti0090
force-pushed
the
product-image-querrying
branch
from
8627964
to
a6c166f
Compare
stloyd
reviewed
Aug 5, 2021
Comment on lines
+37
to
+49
| return $this->removeAdminFilters($filters); | ||
| } | ||
|
|
||
| private function removeAdminFilters(array $filters): array { | ||
| /** @var string $filter */ | ||
| foreach ($filters as $key => $filter) { | ||
| if (str_contains($key, 'admin')) { | ||
| unset($filters[$key]); | ||
| } | ||
| } | ||
|
|
||
| return $filters; | ||
| } |
There was a problem hiding this comment.
Suggested change
| return $this->removeAdminFilters($filters); | |
| } | |
| private function removeAdminFilters(array $filters): array { | |
| /** @var string $filter */ | |
| foreach ($filters as $key => $filter) { | |
| if (str_contains($key, 'admin')) { | |
| unset($filters[$key]); | |
| } | |
| } | |
| return $filters; | |
| } | |
| return array_filter($filters, function ($key) { | |
| return str_contains($key, 'admin'); | |
| }, ARRAY_FILTER_USE_KEY); | |
| } |
GSadee
approved these changes
Aug 6, 2021
Comment on lines
+2
to
+7
| "@context": "\/api\/v2\/contexts\/ProductImage", | ||
| "@id": "\/api\/v2\/shop\/product-images\/@integer@", | ||
| "@type": "ProductImage", | ||
| "id": "@integer@", | ||
| "type": "thumbnail", | ||
| "path": "@string@\/media\/cache\/resolve\/sylius_small\/uo\/product.jpg" |
There was a problem hiding this comment.
Use 4 spaces instead of 2 as indentation
| { | ||
| $fixtures = $this->loadFixturesFromFiles(['product_image.yaml', 'authentication/api_administrator.yaml']); | ||
| /** @var ProductImageInterface $productImage */ | ||
| $productImage = $fixtures["product_thumbnail"]; |
There was a problem hiding this comment.
Suggested change
| $productImage = $fixtures["product_thumbnail"]; | |
| $productImage = $fixtures['product_thumbnail']; |
|
Thanks, @arti0090! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment it adds 'filtered_path' with normal 'path'.
You can choose filter from list
