Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Fix shipping totals in order summary #12875

Merged
merged 1 commit into from Aug 17, 2021
Merged

[Admin] Fix shipping totals in order summary #12875

merged 1 commit into from Aug 17, 2021

Conversation

aleho
Copy link
Contributor

@aleho aleho commented Aug 10, 2021

Q A
Branch? 1.9
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

The extra wrapping div breaks Semantic UI's list here.

before

I'm guessing the intended layout was this?
after

@aleho aleho requested a review from a team as a code owner August 10, 2021 08:55
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Aug 10, 2021
Arminek
Arminek approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@Arminek Arminek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! Thank you @aleho

@lchrusciel lchrusciel merged commit 3069c1f into Sylius:1.9 Aug 17, 2021
@lchrusciel
Copy link
Member

Thank you, Alexander! 🥇

@aleho aleho deleted the fix/order-summary-shipping-totals branch November 25, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@Arminek Arminek Arminek approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aleho @lchrusciel @Arminek